refactor(web): move model/types to web/types 🏗️
#12370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
changed the title
model/types to web/typesmodel/types to web/types 🏗️
ermshiperete
force-pushed
the
refactor/web/12133_models2
branch
from
6edff3a to
0da4d57
Compare
ermshiperete
force-pushed
the
refactor/web/12133_models2
branch
from
0da4d57 to
c3e5871
Compare
ermshiperete
requested review from
jahorton,
mcdurdin and
darcywong00
as code owners
mcdurdin
approved these changes
Sep 10, 2024
common/web/types/src/main.ts
Outdated
| @@ -29,3 +29,5 @@ export * as KMXPlus from './kmx/kmx-plus/kmx-plus.js'; | |||
| export { UnicodeSetParser, UnicodeSet } from './ldml-keyboard/unicodeset-parser-api.js'; | |||
| export { VariableParser, MarkerParser } from './ldml-keyboard/pattern-parser.js'; | |||
| export { ElementString } from './kmx/kmx-plus/element-string.js'; | |||
|
|
|||
| export * from './lexical-model-types.js'; | |||
There was a problem hiding this comment.
Can we enumerate all the exports here? It's busy work but it helps us be explicit about what is a supported API surface. You'll note that we do not have other top-level global exports; they are all * as xxxx.
Addresses code review comments.
|
@mcdurdin I added the change to the release notes section in the Google Doc. Does the breaking change has to be added elsewhere? |
That is all we need -- it'll make its way from there into the 18.0 release notes eventually |
Missed a few exports in the last commit.
|
Changes in this pull request will be available for download in Keyman version 18.0.108-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part-of: #12133
@keymanapp-test-bot skip