Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(web): move common/web/eslint → common/tools/eslint 🏗️ #12390

Merged
merged 2 commits into from
Sep 12, 2024
Merged

refactor(web): move common/web/eslint → common/tools/eslint 🏗️ #12390

merged 2 commits into from
Sep 12, 2024

Conversation

ermshiperete
Copy link
Contributor

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Sep 10, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S10 milestone Sep 10, 2024
@ermshiperete ermshiperete force-pushed the refactor/web/12386_eslint branch from f405c7b to 1fe6a03 Compare September 10, 2024 17:17
@github-actions github-actions bot added web/ and removed web/ labels Sep 10, 2024
mcdurdin
mcdurdin approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is an eslint module that would be great to use in KMW's DOM and shared modules... so IMO it does belong in common/tools.

@github-actions github-actions bot added web/ and removed web/ labels Sep 11, 2024
@ermshiperete ermshiperete linked an issue Sep 11, 2024 that may be closed by this pull request
refactor(web): move common/web/eslint → common/tools/eslint #12386
Closed
Base automatically changed from refactor/web/12385_es-bundling to master September 12, 2024 06:49
@ermshiperete ermshiperete merged commit 9e15a38 into master Sep 12, 2024
21 checks passed
@ermshiperete ermshiperete deleted the refactor/web/12386_eslint branch September 12, 2024 06:50
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.110-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

@rc-swag rc-swag Awaiting requested review from rc-swag rc-swag is a code owner

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

Assignees
No one assigned
Labels
common/ refactor web/
Projects
Keyman
Archived in project
Milestone
A18S10
Development

Successfully merging this pull request may close these issues.

refactor(web): move common/web/eslint → common/tools/eslint
3 participants
@ermshiperete @keyman-server @mcdurdin