Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(developer): copy dev 17.0 help into repo #12427

Merged
merged 4 commits into from
Sep 28, 2024

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Sep 16, 2024

First commit:

  1. Copy help.keyman.com/developer/17.0/* into /developer/docs/help
  2. Update references to 18.0 where appropriate
  3. Copy all referenced images from /cdn/dev into /developer/docs/help/images and update links in documentation

Second commit adds deployment to help-keyman-com.sh.

Note: simplest way to test links at this point is to use the help.keyman.com auto deploy and wait for the PR on help.keyman.com to be validated; we could look at an internal link validation tool that verifies markdown links? (now done in #12472)

Relates-to: #12347

@keymanapp-test-bot skip

1. Copy help.keyman.com/developer/17.0/* into /developer/docs/help
2. Update references to 18.0 where appropriate
3. Copy all referenced images from /cdn/dev into
   /developer/docs/help/images and update links in documentation

Next commit: add deployment to help-keyman-com.sh. Note: simplest way to
test links at this point is to use the help.keyman.com auto deploy and
wait for the PR on help.keyman.com to be validated; we could look at an
internal link validation tool that verifies markdown links?

Relates-to: #12347
@mcdurdin mcdurdin marked this pull request as ready for review September 26, 2024 15:16
Base automatically changed from refactor/common/12347-reorg-help to master September 26, 2024 15:40
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@darcywong00 darcywong00 modified the milestones: A18S11, A18S12 Sep 28, 2024
@mcdurdin mcdurdin merged commit 2d21b21 into master Sep 28, 2024
28 checks passed
@mcdurdin mcdurdin deleted the refactor/developer/12347-move-help-in-repo branch September 28, 2024 02:34
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.119-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants