Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Remove toggle for "Always Show Banner" #12430

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

darcywong00
Copy link
Contributor

Fixes #12376

The "Always show banner" toggle was originally reserved for future features. As of Keyman 17.0 though, there will always be a banner above the OSK (displaying either suggestions or an HTML bannner).

This removes the toggle from the Keyman settings screen. And also updates the in-app help.

User Testing

  • Setup - Install the PR build of Keyman for Android on a modern device/emulator. (I noticed the emulator for Android 8.1 [API 27] has an old version of Chrome so the suggestion banner is broken)

TEST_BANNER TOGGLE_REMOVED - Verifies banner toggle is gone

  1. Launch Keyman for Android and dismiss the "Get Started" menu
  2. With the default sil_euro_latin keyboard start typing
  3. Verify suggestion banner provides suggestions.
  4. Open Keyman settings
  5. Verify the toggle to always show banner is removed (it used to come after "Vibrate when typing")
  6. Exit Keyman settings
  7. From the Keyman menu, open the Info page (in-app help)
  8. Scroll down to Using Keyman for Android heading and select Using the Settings Screen
  9. Verify the screenshot for Step 2) does not include Always show banner
  10. Scroll down to Vibrate When Typing section
  11. Verify the next section is Show "Get Started" on startup

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Sep 17, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Sep 17, 2024

@dinakaranr
Copy link

Test Results

I tested this issue with the attached "Keyman 18.0.114-alpha-test-12430" build on the Android 14 mobile(physical device) and Android 12(emulator). Here is my observation.

  • TEST_BANNER (Passed):
  1. Installed the "Keyman-18.0.114.apk" file from the PR build.
  2. Open the Keyman app.
  3. Close the "Get Started" menu
  4. Verified the suggestion banner provides suggestions while typing text in the keyman's note tab.
  5. Open the settings menu by clicking the ellipsis button.
  6. Verified the toggle to "always show banner" is removed.
  7. Close the keyman's settings menu.
  8. Open the "Info" page by clicking the ellipsis button.
  9. Scroll down to the "Using Keyman for Android" heading and select "Using the Settings Screen"
  10. Verified the step 2 screenshot did not have the "Always show banner"
  11. Scroll down to the "Vibrate When Typing" section
  12. Verified the next section is "Show 'Get Started' on startup"
    It works great for me. Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Sep 17, 2024
@darcywong00 darcywong00 merged commit f06d88b into master Sep 25, 2024
6 checks passed
@darcywong00 darcywong00 deleted the fix/android/banner-toggle branch September 25, 2024 00:07
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.117-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug(android): "Always show banner" has no effect
4 participants