feat(mac): both option keys generate right alt if no left alt mapping #12458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
has-user-test
user-test-required
mcdurdin
approved these changes
Sep 28, 2024
| @@ -67,6 +64,38 @@ -(void)changeKeyboardWithKmxFilePath:(NSString*) path { | |||
| } | |||
| } | |||
|
|
|||
| -(CoreKeyboardInfo*) getKeyboardInfoForKmxFile:(NSString*)kmxFile { | |||
| NSArray *keyArray = [self getKeyArray]; | |||
| CoreKeyboardInfo* info = [[CoreKeyboardInfo alloc] init:kmxFile keyArray: keyArray]; | |||
There was a problem hiding this comment.
Is keyArray and its members leaked here?
There was a problem hiding this comment.
no, by default there is a strong reference to the key array in CoreKeyboardInfo which is dealloced when the keyboard is changed
| NSMutableArray *keyArray = [[NSMutableArray alloc] initWithCapacity:0]; | ||
| km_core_keyboard_key *keyList; | ||
|
|
||
| km_core_status result = km_core_keyboard_get_key_list(self.coreKeyboard, &keyList); |
There was a problem hiding this comment.
yes, adding a call to km_core_keyboard_key_list_dispose
Test ResultsI tested this issue with the attached "Keyman 18.0.118-alpha-local" build on the macOS Sonoma 14.5 version. here, I am sharing my observation.
It works well. Thank you. |
keymanapp-test-bot
bot
removed
the
user-test-required
memory leak of key list without disposing
|
Changes in this pull request will be available for download in Keyman version 18.0.122-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a keyman keyboard does not define any rules for the Left Alt key, then both the left and right option keys on the Mac keyboard should result in a Right Alt key combination being generated.
Fixes: #875
Fixes: #933
User Testing