chore(common): consolidate common meson patterns and use 'c++17' in standard.meson.build 🐘 #12496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meson-utils.inc.sh
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
SabineSIL
changed the base branch from
epic/linux-mcompile
to
feat/mac/mcompile_mac
…ild and do_test to meson-utils.inc.sh
…github.com/keymanapp/keyman into chore/mac/mcompile_mac-CommonMesonPatterns
…github.com/keymanapp/keyman into chore/mac/mcompile_mac-CommonMesonPatterns
github-actions
bot
added
android/
android/app/
android/engine/
common/web/
developer/
developer/compilers/
developer/ide/
docs
ios/
linux/config/
oem/
oem/fv/
web/
windows/
windows/config/
and removed
developer/compilers/
oem/
android/engine/
android/app/
linux/config/
common/web/
developer/ide/
oem/fv/
windows/config/
docs
labels
mcdurdin
approved these changes
Oct 11, 2024
|
Process note: we don't normally merge PRs into other open PR branches, because that makes review of the parent PR more difficult. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while reviewing PR #11334 we found that 2 things could be changed in standard.meson.build and resources/build/meson-utils.inc.sh:
standard.meson.build :
set version of C++ to ['-std=c++17'] to be able to define from resources/standard.meson.build
resources/build/meson-utils.inc.sh:
do_clean(), do_configure(), do_build(), do_test() are functions that are common meson patterns we could consolidate into resources/build/meson-utils.inc.sh
see issue #12433 and issue #12526
@keymanapp-test-bot skip