chore(developer,common): deps: replace xml2js with fast-xml-parser #12502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove vendored xml2js - add [email protected] - Rewire the KeymanXMLReader / KeymanXMLWriter to use fast-xml-parser Four small changes to the test data on the generated .kvks: - allow " for XML generation (" is legal) - use the same XML prologue as the actual .kvks files. - treat <key></key> as <key/> since we can't distinguish (removed a "_": "" entry) - remove whitespace because we now can ("_": "\n \n \n") on non-leaf nodes. This is ignored by the kvks code, but was difficult to maintain roundtrip. Fixes: #12208
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
- because of the form to="" in ldml, we need to distinguish attributes and sub-elements in the ldml xml parsing - use an attributePrefix, and fixup the object tree afterwards Fixes: #12208
mcdurdin
changed the title
|
Changes in this pull request will be available for download in Keyman version 18.0.123-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four small changes to the test data on the generated .kvks:
"for XML generation ("is legal)<key></key>as<key/>since we can't distinguish (removed a"_": ""entry)"_": "\n \n \n") on non-leaf nodes. This is ignored by the kvks code, but was difficult to maintain roundtrip.Fixes: #12208
Supersedes: #12331 (due to the approach in #12482)
@keymanapp-test-bot skip