Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oem/fv): Update keyboard versions and names for fv_all.kmp 🏠 #12504

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

darcywong00
Copy link
Contributor

🍒 pick of #12461 to stable-17.0

This updates keyboard versions and names in keyboards.csv to match the latest fv_all.kmp file.

User Testing

Setup Install the PR build of FirstVoices for Android on device/emulator

  • TEST_VERSION_NAMES - Verify keyboard versions and names updated
  1. Launch FirstVoices app and go to "Select keyboards" menu
  2. For the regions below, verify keyboard versions and names match the table below
  • BC Coast
Keyboard Name Keyboard Version
Haíɫzaqvḷa 10.0
Sḵwx̱wú7mesh (snichim) 10.0
X̄aʼislak̓ala 10.0
Éy7á7juuthem 10.2
’Wuìk̓ala 9.4
  • BC Interior
Keyboard Name Keyboard Version
Nsyilxcən 10.0.1
Tāłtān 9.2
  • Western Subarctic
Keyboard Name Keyboard Version
Danezāgéʼ 11.0.1
Dene Zhatıé 10.2.1
Dënesųłıné 10.0.1
Dɛnɛsųłįnɛ 10.0.2

@darcywong00 darcywong00 added this to the A18S12 milestone Oct 4, 2024
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Oct 4, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 4, 2024

@github-actions github-actions bot added the fix label Oct 4, 2024
@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(oem/fv): Update keyboard versions and names for fv_all.kmp fix(oem/fv): Update keyboard versions and names for fv_all.kmp 🏠 Oct 4, 2024
@darcywong00
Copy link
Contributor Author

Build artifact for FirstVoices apk

@dinakaranr
Copy link

Test Results

I tested this issue with the attached "Keyman-17.0.331-test-12504.apk and firstvoices-17.0.331.apk" build on the Android 14 mobile & emulator. I'm sharing my observation here.

  • TEST_VERSION_NAMES (Passed):
  1. Installed the "Keyman-17.0.331.apk" file from the PR build. and gave all permissions to the application.
  2. Checked the "Enable Keyman as system-wide keyboard" on the settings page. Checked the "Set Keyman as default keyboard".
  3. Installed the "firstvoices-17.0.331.apk" file from the PR build.
  4. Go to the "Select Keyboards" menu.
  • Select the "BC Coast" menu
  • Verified keyboard name & version matched.
  • Haíɫzaqvḷa 10.0, Sḵwx̱wú7mesh (snichim) 10.0, X̄aʼislak̓ala 10.0, Éy7á7juuthem 10.2, ’Wuìk̓ala 9.4
  • Select the BC Interior
  • Verified keyboard name & version matched.
  • Nsyilxcən 10.0.1, Tāłtān 9.2
  • Select the Western Subarctic
  • Verified keyboard name & version matched.
  • Danezāgéʼ 11.0.1, Dene Zhatıé 10.2.1, Dënesųłıné 10.0.1, Dɛnɛsųłįnɛ 10.0.2
    It works well, Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Oct 4, 2024
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@darcywong00 darcywong00 merged commit 2027f7e into stable-17.0 Oct 7, 2024
6 checks passed
@darcywong00 darcywong00 deleted the cherrypick/fv/mobile-updates branch October 7, 2024 01:51
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants