Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(web): move KeyboardObject type to common/web/types #12514

Merged
merged 4 commits into from
Oct 10, 2024
Merged

refactor(web): move KeyboardObject type to common/web/types #12514

merged 4 commits into from
Oct 10, 2024

Conversation

ermshiperete
Copy link
Contributor

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 8, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S12 milestone Oct 8, 2024
mcdurdin
mcdurdin requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on detangling thus far. I would like to take it a little further, I think. The intent of common-types is for it to describe file formats, not implementations. So ideally, outputTarget should not be exposed in common-types. See my further comments inline.

common/web/types/build.sh Outdated Show resolved Hide resolved
common/web/types/src/keyboard-object.ts Outdated Show resolved Hide resolved
common/web/types/src/keyboard-object.ts Outdated Show resolved Hide resolved
common/web/types/src/keyboard-object.ts Outdated Show resolved Hide resolved
common/web/types/src/main.ts Outdated Show resolved Hide resolved
@mcdurdin mcdurdin mentioned this pull request Oct 9, 2024
Closed
@ermshiperete ermshiperete requested a review from mcdurdin October 9, 2024 18:34
@ermshiperete ermshiperete force-pushed the refactor/web/11612_keyboardobj branch from 51e87ef to 9885a47 Compare October 9, 2024 18:38
mcdurdin
mcdurdin requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking closer -- I see build failures though with KMW (Windows/Developer failures are related to codesigning I think)

common/web/types/build.sh Outdated Show resolved Hide resolved
common/web/types/src/main.ts Outdated Show resolved Hide resolved
@mcdurdin
Copy link
Member

I see a bunch of minor formatting changes, e.g. "' --> ' -- is it worth stripping those out to reduce the potential for merge conflicts with other PRs?

@ermshiperete ermshiperete requested a review from mcdurdin October 10, 2024 07:15
mcdurdin
mcdurdin approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your persistence 😁

@ermshiperete ermshiperete merged commit 71a1b6c into master Oct 10, 2024
21 checks passed
@ermshiperete ermshiperete deleted the refactor/web/11612_keyboardobj branch October 10, 2024 10:01
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.125-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

Assignees
No one assigned
Labels
common/web/ common/ refactor web/
Projects
Keyman
Archived in project
Milestone
A18S12
Development

Successfully merging this pull request may close these issues.

refactor(web): hoist KeyboardObject type to common/web/types
3 participants
@ermshiperete @mcdurdin @keyman-server