refactor(developer): add kps-file-reader and kps-file-writer #12545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to kmc-copy project. Moves the .kps file reader out of kmc-package and adds corresponding kps file writer unit in developer-utils. Also moves related test and error message definition.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
darcywong00
reviewed
Oct 21, 2024
| let a: KpsPackage; | ||
|
|
||
| try { | ||
| a = new KeymanXMLReader('kps') |
There was a problem hiding this comment.
Maybe overkill, but thoughts on using KeymanXMLType.kps instead of 'kps'?
On kps-file-writer.ts too
There was a problem hiding this comment.
It's not needed because Typescript type-checks the string so invalid strings aren't accepted
|
Changes in this pull request will be available for download in Keyman version 18.0.131-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to kmc-copy project.
Moves the .kps file reader out of kmc-package and adds corresponding kps file writer unit in developer-utils. Also moves related test and error message definition.
@keymanapp-test-bot skip