fix(core): fix generated core.js file for debug builds 🎼
#12550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
core.js file for debug buildscore.js file for debug builds 🎼
Due to emscripten bug emscripten-core/emscripten#22754 specifying only `webview` as environment resulted in a broken `core.js` file when doing a debug build. In release builds things worked because of the `-Wl,-O1 -O2` that meson added for the release build. This change works around that bug by adding `web` as additional environment.
ermshiperete
force-pushed
the
fix/core/debugbuild
branch
from
8737569 to
998ad76
Compare
I imagine we'd want web as well as webview in any case? |
mcdurdin
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to emscripten bug emscripten-core/emscripten#22754 specifying only
webviewas environment resulted in a brokencore.jsfile when doing a debug build. In release builds things worked because of the-Wl,-O1 -O2that meson added for the release build. This change works around that bug by addingwebas additional environment.@keymanapp-test-bot skip