feat(windows): kmdevlink app #12552
Merged
feat(windows): kmdevlink app #12552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal app for opening shortcuts to Keyman repos and Character Identifier.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
darcywong00
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
lgtm
Couple of questions:
- Is this intended to be locally built as-needed by developers that want to use it?
- Could you add a short README of what this tool is for / how to build it?
- Are the copyrights in the code still under Tavultesoft vs SIL Global? (Falls under the MIT license of the whole repo?)
|
This will be the binary version of kmdevlink for now: |
|
Changes in this pull request will be available for download in Keyman version 18.0.132-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal app for opening shortcuts to Keyman repos and Character Identifier.
Stripped down version of the old 'tscrmlink' app which was used in Tavultesoft era. Hence why it is written in Delphi...
@keymanapp-test-bot skip