-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(developer): kmc-copy #12555
Merged
Merged
feat(developer): kmc-copy #12555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User tests have not yet been defined for the PR
label
Oct 17, 2024
User Test ResultsTest specification and instructions Test Artifacts
|
github-actions
bot
added
developer/
common/
developer/compilers/
common/web/
feat
labels
Oct 17, 2024
mcdurdin
force-pushed
the
feat/developer/kmc-copy
branch
from
October 21, 2024 06:02
2cf5db1
to
e99d950
Compare
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User tests have not been completed
and removed
user-test-missing
User tests have not yet been defined for the PR
labels
Oct 22, 2024
Relates to kmc-copy project. Moves the .kps file reader out of kmc-package and adds corresponding kps file writer unit in developer-utils. Also moves related test and error message definition.
* Hides details on --rename and online sources for projects until implemented
mcdurdin
force-pushed
the
feat/developer/kmc-copy
branch
from
October 22, 2024 03:28
7d10290
to
6df121a
Compare
keymanapp-test-bot
bot
removed
the
user-test-required
User tests have not been completed
label
Oct 29, 2024
darcywong00
reviewed
Oct 31, 2024
darcywong00
reviewed
Oct 31, 2024
darcywong00
reviewed
Oct 31, 2024
developer/src/kmc-copy/test/fixtures/projects/alephwithbeth/build/alephwithbeth.keyboard_info
Show resolved
Hide resolved
darcywong00
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
19 tasks
Changes in this pull request will be available for download in Keyman version 18.0.138-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2264.
Basic functionality for cloning and renaming a keyboard project with the
kmc copy
command. Many TODO-COPY items are resolved in #12586. Others to come.Note: TODO list moved to #12641.
User Testing
Install Keyman Developer
Open a command prompt
TEST_COPY_KEYBOARDS: Try to copy an existing keyboard project with the
kmc copy
command:kmc copy <source-project.kpj> -o <destination-folder>
, e.g.kmc copy keyboards/release/k/khmer_angkor -o c:\temp\my_first_cambodian_keyboard
. Do this with a few different keyboards. Verify that the copy and rename worked by building the new keyboards and verify that they build. Verify that the filenames are as expected in the new keyboards.TEST_COPY_MODELS: Try to copy an existing lexical model project with the
kmc copy
command:kmc copy <source-project.kpj> -o <destination-folder>
, e.g.kmc copy lexical-models/release/sil/sil.km.cnd -o c:\temp\mydict.km.cambodian
. Do this with a few different lexical models. Verify that the copy and rename worked by building the new models and verify that they build. Verify that the filenames are as expected in the new models.