Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mac): support missing alt layers in OSK #12565

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

sgschantz
Copy link
Contributor

@sgschantz sgschantz commented Oct 21, 2024

When selecting an alt layer (corresponds to the option key on Mac) of the on-screen keyboard, display the keys that are output from Keyman for the designated layer as defined in the keyboard's KVK file.

Fixes: #5721

User Testing

  • TEST_RALT_KEYBOARD_WITH_OSK: Khmer Angkor uses only RALT rules
  1. Install this version of Keyman and switch to the Khmer Angkor keyboard
  2. Open the OSK
  3. Click on the Alt key on the OSK to display its Alt layer
  4. Confirm that the L key displays the character '៘'
  • TEST_ALT_KEYBOARD_WITH_OSK: Tibetan EWTS uses only ALT rules
  1. Install this version of Keyman and switch to the Tibetan EWTS keyboard
  2. Open the OSK
  3. Click on the Alt key on the OSK to display its Alt layer
  4. Confirm that the 7 key displays the character '༧'

@sgschantz sgschantz added this to the A18S13 milestone Oct 21, 2024
@sgschantz sgschantz self-assigned this Oct 21, 2024
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Oct 21, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 21, 2024

User Test Results

Test specification and instructions

Test Artifacts

@sgschantz sgschantz marked this pull request as ready for review October 21, 2024 08:35
@sgschantz sgschantz requested a review from SabineSIL as a code owner October 21, 2024 08:35
@dinakaranr
Copy link

Test Results

Installed "Keyman 18.0.126-alpha-local" build on the macOS Sonoma 14.5. Installed the Khmer Angkor and Tibetan EWTS keyboard.

  • TEST_RALT_KEYBOARD_WITH_OSK (Passed):
  1. Select the Khmer Angkor keyboard
  2. Open the OSK
  3. Open the Notes app
  4. Click on the Alt key on the OSK to display its Alt layer
  5. Verified that the L key displays the character '៘'
    It works well, There is no problem when pressing the right Alt key on OSK.
  • TEST_ALT_KEYBOARD_WITH_OSK (Passed):
  1. Select the Tibetan EWTS keyboard.
  2. Open the OSK
  3. Open the Notes app
  4. Click on the Alt key on the OSK to display its Alt layer
  5. Verified that the 7 key displays the character '༧'
    It works well, There is no problem when pressing the right/left Alt key on OSK.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Oct 21, 2024
Base automatically changed from fix/mac/6578-ineffective-osk-modifiers to master October 25, 2024 08:58
@sgschantz sgschantz merged commit a4b9b9f into master Oct 25, 2024
5 checks passed
@sgschantz sgschantz deleted the fix/mac/5721-OSK-alt-layers-missing branch October 25, 2024 08:58
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.131-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug(mac): OSKs of Alt and Alt+Shift on macOS are not consistent with those on Windows
4 participants