feat(windows): set the update state machine to idle in first run 💽 #12621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
… feat/windows/set-sm-idle-firstrun
Base automatically changed from
feat/windows/add-apply-now-update
to
epic/windows-updates
November 12, 2024 03:44
…/set-sm-idle-firstrun
# Keyman Conventional Commit suggestions:
#
# - Link to a Sentry issue with git trailer:
# Fixes: _MODULE_-_ID_
# - Give credit to co-authors:
# Co-authored-by: _Name_ <_email_>
# - Use imperative, present tense ('attach' not 'attaches', 'attached' etc)
# - Don't include a period at the end of the title
# - Always include a blank line before trailers
# - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
Remove the retry state as the process will retry in the same process. Future we could consider adding a retry state that would retry on the next time kmshell is started for any reason.
Update all the errors logged using KLog to sentry messages
Remove the update of state from the insthelper as configure first run will now set it back to idle.
keymanapp-test-bot
bot
removed
the
user-test-missing
…/set-sm-idle-firstrun
# Keyman Conventional Commit suggestions:
#
# - Link to a Sentry issue with git trailer:
# Fixes: _MODULE_-_ID_
# - Give credit to co-authors:
# Co-authored-by: _Name_ <_email_>
# - Use imperative, present tense ('attach' not 'attaches', 'attached' etc)
# - Don't include a period at the end of the title
# - Always include a blank line before trailers
# - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
ermshiperete
approved these changes
Dec 16, 2024
windows/src/desktop/kmshell/main/Keyman.System.UpdateStateMachine.pas
Outdated
Show resolved
Hide resolved
windows/src/desktop/kmshell/main/Keyman.System.UpdateStateMachine.pas
Outdated
Show resolved
Hide resolved
windows/src/desktop/kmshell/main/Keyman.System.UpdateStateMachine.pas
Outdated
Show resolved
Hide resolved
Co-authored-by: Eberhard Beilharz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR on to the epic moves the handling of cleaning up the install files to the Kmshell process and as part of the
Keyman.System.Update.StateMachine.pas.TODO: Future PRs continue the epic work see #10038
#12794 Adds Installing packages
Also need to clean up the Update tag in configuration.
@keymanapp-test-bot skip