Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): permanently disable logging 🏠 #12674

Open
wants to merge 1 commit into
base: stable-17.0
Choose a base branch
from

Conversation

ermshiperete
Copy link
Contributor

This change disables logging at compile time to work around #12661. Logging can be enabled in the debugger, or by re-compiling with g_debug_KeymanLog set to TRUE.

Related: #12661

User Testing

TEST_NOLOG: Run this test on Linux to verify that logging is disabled

  • open a terminal window and show the syslog: tail -f /var/log/syslog
  • switch to a Keyman keyboard and type a few characters in any application, e.g. Writer
  • verify that a keypress doesn't output lines containing ibus-engine-keyman in the syslog

This change disables logging at compile time to work around #12661.
Logging can be enabled in the debugger, or by re-compiling with
`g_debug_KeymanLog` set to TRUE.

Related: #12661
@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(core): permanently disable logging fix(core): permanently disable logging 🏠 Nov 14, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S15 milestone Nov 14, 2024
@mcdurdin
Copy link
Member

@rc-swag does this impact Windows?
@sgschantz does this impact macOS?

Obviously we need a separate interface for debug for Core.

@dinakaranr
Copy link

Test Results

I tested this issue with the attached Keyman "17.0.333" (package version 17.0.333-1~PR-12674-4017.1+jammy1) build on the Noble & Jammy. Here is my observation.

  • TEST_NOLOG (Passed): 
  1. Installed the "17.0.333-1~PR-12674-4017.1+jammy1" file.
  2. Open the terminal window and then run the "tail -f /var/log/syslog" command.
  3. Installed the "Khmer Angkor" keyboard on the "Keyman Configuration" dialog.
  4. Open the text editor application.
  5. Change the keyboard from English to Khmer keyboard.
  6. Enter the text in the text editor application.
  7. Verified that the "ibus-engine-keyman" log message did not appear in the syslog. 
    (When switching the keyboard or when typing a text.) Please take a look at the screenshot.
    It works well. 
    Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Nov 15, 2024
@darcywong00 darcywong00 modified the milestones: A18S15, A18S16 Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants