Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): rename test files #12709

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

ermshiperete
Copy link
Contributor

This change rename the test files in Common according to the discussion at the Keyman conference in November 2024.

@keymanapp-test-bot skip

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S16 milestone Nov 26, 2024
@ermshiperete ermshiperete changed the base branch from master to refactor/common/tc_tests November 27, 2024 15:10
Base automatically changed from refactor/common/tc_tests to master November 28, 2024 12:41
@ermshiperete ermshiperete force-pushed the chore/common/rename-tests branch from cb4332c to 37600c3 Compare November 28, 2024 13:34
This change rename the test files in Common according to the discussion
at the Keyman conference in November 2024.
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is it worth renaming the folder to tests at the same time? It's a small additional change to this PR and saves more busywork later

@ermshiperete ermshiperete merged commit 9a6e336 into master Dec 4, 2024
21 checks passed
@ermshiperete ermshiperete deleted the chore/common/rename-tests branch December 4, 2024 08:03
ermshiperete added a commit that referenced this pull request Dec 4, 2024
This change renames a new test file and moves it to the new location.
This file was overlooked in #12709.
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.152-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants