refactor(common): move remaining LDML keyboard types into LdmlKeyboardTypes
#12713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdTypes` Follows: #12712
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
developer/
common/
developer/compilers/
common/web/
refactor
labels
mcdurdin
requested review from
darcywong00,
SabineSIL,
markcsinclair,
srl295 and
jahorton
as code owners
darcywong00
reviewed
Nov 27, 2024
| */ | ||
| export { UnicodeSetParser, UnicodeSet } from './ldml-keyboard/unicodeset-parser-api.js'; | ||
| export { VariableParser, MarkerParser } from './ldml-keyboard/pattern-parser.js'; | ||
| export { ElementString } from './kmx/kmx-plus/element-string.js'; |
There was a problem hiding this comment.
Should this be separate from LdmlKeyboardTypes?
In #12712, I thought I saw ElementString exported separately from LexicalModelTypes.
There was a problem hiding this comment.
No, ElementString is not exported from LexicalModelTypes. There is just a unit test that refers to ElementString which was impacted by the update in #12712.
There's a bit of fuzziness between KMXPlus and LDMLKeyboard (because KMXPlus is an implementation for LDMLKeyboard spec) and I think for now, the layout I have is probably oaky.
Base automatically changed from
refactor/common/12516-LexicalModelTypes
to
master
November 27, 2024 06:20
|
Changes in this pull request will be available for download in Keyman version 18.0.146-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows: #12712
@keymanapp-test-bot skip