feat(core,linux,developer,windows): implement loading KMX from blob 🍒 #12721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- split keyboard loading into loading KMX file into blob and then loading the keyboard processor from the blob. - deprecate `km_core_keyboard_load` - move file access next to deprecated method. This is now the only place that loads a file in Core; unit tests have some more places that load files. - introduce GTest and add unit tests for loading from blob Cherry-picked from `epic/web-core` branch. Cherry-Pick-Commit: 1deaa32 Cherry-Pick-Commit: 59019cc Cherry-Pick-Commit: bc46458 Cherry-Pick-Commit: d06aa29 Cherry-Pick-Commit: 1c88166 Cherry-Pick-Commit: 069cd21 Cherry-Pick-Commit: 052ae2e Cherry-Pick-Commit: 11a2a3b Part-of: #11293 Part-of: #8093
ermshiperete
requested review from
darcywong00,
mcdurdin,
SabineSIL,
markcsinclair,
srl295 and
rc-swag
as code owners
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
developer/
linux/
linux/engine/
core/
ermshiperete
changed the title
keymanapp-test-bot
bot
removed
the
user-test-missing
github-actions
bot
added
windows/
windows/engine/
cherry-pick
ermshiperete
changed the title
|
Done |
mcdurdin
approved these changes
Nov 28, 2024
|
Changes in this pull request will be available for download in Keyman version 18.0.148-alpha |
srl295
reviewed
Nov 29, 2024
Comment on lines
37
to
39
| static bool is_kmxplus_file( | ||
| path const & kb_path, | ||
| std::vector<uint8_t>& data | ||
| const std::vector<uint8_t> & data | ||
| ); |
There was a problem hiding this comment.
NB: the declaration here was left even though the implementation is gone - I'll fix it in #12644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick from
epic/web-coreof the new Core API for loading a KMX keyboard from a blob so that it can be included in Keyman 18.loading the keyboard processor from the blob.
that loads a file in Core; unit tests have some more places that
load files.
Cherry-picked from
epic/web-corebranch.Cherry-Pick-Commit: 1deaa32
Cherry-Pick-Commit: 59019cc
Cherry-Pick-Commit: bc46458
Cherry-Pick-Commit: d06aa29
Cherry-Pick-Commit: 1c88166
Cherry-Pick-Commit: 069cd21
Cherry-Pick-Commit: 052ae2e
Cherry-Pick-Commit: 11a2a3b
Part-of: #11293
Part-of: #8093
Fixes: #12498
Cherry-pick: #12683
Fixes: #12690
Cherry-pick: #12711
Fixes: #12500
Cherry-pick: #12684
@keymanapp-test-bot skip