Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(common): improve offline builds #12739

Merged
merged 1 commit into from
Nov 28, 2024
Merged

chore(common): improve offline builds #12739

merged 1 commit into from
Nov 28, 2024

Conversation

ermshiperete
Copy link
Contributor

nvm install will fail if trying to build while offline. This change tries to use the required node version first and if that fails installs and then uses it.

@keymanapp-test-bot skip

@ermshiperete
chore(common): improve offline builds
ddb6631 
`nvm install` will fail if trying to build while offline. This
change tries to use the required node version first and if that
fails installs and then uses it.
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 28, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S16 milestone Nov 28, 2024
mcdurdin
mcdurdin approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offline builds will surely trip over on the next step, npm ci so not sure this helps all that much?

@ermshiperete
Copy link
Contributor Author

We will see. In theory it should work if you build with the current dependencies before and if you pass the --offline flag to the build (and once #12740 is also merged).

@ermshiperete ermshiperete merged commit a842d41 into master Nov 28, 2024
29 checks passed
@ermshiperete ermshiperete deleted the chore/common/nvm-offline branch November 28, 2024 13:36
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.147-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

@srl295 srl295 Awaiting requested review from srl295 srl295 is a code owner

Assignees
No one assigned
Labels
chore common/resources/ Build infrastructure common/
Projects
Keyman
Archived in project
Milestone
A18S16
Development

Successfully merging this pull request may close these issues.
3 participants
@ermshiperete @keyman-server @mcdurdin