-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common/web): delete replaceExtension in types/src/util/file-types.ts #12762
Merged
markcsinclair
merged 4 commits into
master
from
fix/common/web/types/12761-delete-replaceExtension
Dec 9, 2024
Merged
fix(common/web): delete replaceExtension in types/src/util/file-types.ts #12762
markcsinclair
merged 4 commits into
master
from
fix/common/web/types/12761-delete-replaceExtension
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
8 tasks
markcsinclair
changed the title
fic(common/web): delete replaceExtension in types/src/util/file-types.ts
fix(common/web): delete replaceExtension in types/src/util/file-types.ts
Dec 3, 2024
Base automatically changed from
test/common/web/types/9052-unit-tests-file-types
to
master
December 5, 2024 10:32
…761-delete-replaceExtension
mcdurdin
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…761-delete-replaceExtension
markcsinclair
deleted the
fix/common/web/types/12761-delete-replaceExtension
branch
December 9, 2024 10:16
Changes in this pull request will be available for download in Keyman version 18.0.156-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete
replaceExtension()
intypes/src/util/file-types.ts
and supporting tests intest-file-types.ts
.This PR depends on PR #12716 , where the tests of
replaceExtension()
are created.Fixes: #12761
@keymanapp-test-bot skip