Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common/web): delete replaceExtension in types/src/util/file-types.ts #12762

Merged

Conversation

markcsinclair
Copy link
Contributor

@markcsinclair markcsinclair commented Dec 3, 2024

Delete replaceExtension() in types/src/util/file-types.ts and supporting tests in test-file-types.ts.

This PR depends on PR #12716 , where the tests of replaceExtension() are created.

Fixes: #12761

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 3, 2024

User Test Results

Test specification and instructions

User tests are not required

@markcsinclair markcsinclair self-assigned this Dec 3, 2024
@github-actions github-actions bot added the web/ label Dec 3, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S16 milestone Dec 3, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 3, 2024
@markcsinclair markcsinclair changed the title fic(common/web): delete replaceExtension in types/src/util/file-types.ts fix(common/web): delete replaceExtension in types/src/util/file-types.ts Dec 3, 2024
@markcsinclair markcsinclair marked this pull request as draft December 3, 2024 11:32
Base automatically changed from test/common/web/types/9052-unit-tests-file-types to master December 5, 2024 10:32
@github-actions github-actions bot added web/ and removed web/ labels Dec 5, 2024
@markcsinclair markcsinclair marked this pull request as ready for review December 5, 2024 10:40
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darcywong00 darcywong00 modified the milestones: A18S16, A18S17 Dec 7, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 9, 2024
@markcsinclair markcsinclair merged commit b8cd016 into master Dec 9, 2024
3 checks passed
@markcsinclair markcsinclair deleted the fix/common/web/types/12761-delete-replaceExtension branch December 9, 2024 10:16
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.156-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants