-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(mac): update to SIL logo with glyph in About window #12766
Conversation
User Test ResultsTest specification and instructions Test Artifacts
|
The stripes are supposed to be a thin band -- see keyman.com, and the logo is supposed to be on a white background, otherwise it is lost against the orange. See the design guide on the Google drive: https://drive.google.com/file/d/11Hqm9EeEnY6EEOxALTRbSLz5poLc6FRH/view?usp=drive_link |
due to Sonoma change of default setting in UIView where clipsToBounds is defaulting to false, the stripe in the About box was appearing much taller than the expected 7 points
Now updated to so that the three-color stripe is a thin band 7 points in height. Here is the updated appearance: |
That looks great, thanks! |
Test ResultsI tested this issue with the attached "Keyman 18.0.151-alpha-local" build on macOS Sonoma 14.5.
|
Changes in this pull request will be available for download in Keyman version 18.0.154-alpha |
Change About window from this:
to this:
Note that the new logo used is Andika v1 from: https://sites.google.com/sil.org/brand-resource-center/branding/visual-brand/logos
Fixes: #12159
User Testing