Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mac): update to SIL logo with glyph in About window #12766

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

sgschantz
Copy link
Contributor

Change About window from this:

image

to this:

image

Note that the new logo used is Andika v1 from: https://sites.google.com/sil.org/brand-resource-center/branding/visual-brand/logos

Fixes: #12159

User Testing

  • TEST_ABOUT_WITH_SIL_LOGO: verify new SIL logo appearance
  1. Install and run the Keyman build associated with this PR
  2. Verify that the About window displays the updated SIL logo with accompanying glyph

@sgschantz sgschantz added the mac/ label Dec 4, 2024
@sgschantz sgschantz added this to the A18S16 milestone Dec 4, 2024
@sgschantz sgschantz requested a review from SabineSIL as a code owner December 4, 2024 04:19
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Dec 4, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 4, 2024

User Test Results

Test specification and instructions

Test Artifacts

@github-actions github-actions bot added the chore label Dec 4, 2024
@sgschantz sgschantz self-assigned this Dec 4, 2024
@mcdurdin
Copy link
Member

mcdurdin commented Dec 4, 2024

to this:

image

The stripes are supposed to be a thin band -- see keyman.com, and the logo is supposed to be on a white background, otherwise it is lost against the orange. See the design guide on the Google drive: https://drive.google.com/file/d/11Hqm9EeEnY6EEOxALTRbSLz5poLc6FRH/view?usp=drive_link

due to Sonoma change of default setting in UIView
where clipsToBounds is defaulting to false, the
stripe in the About box was appearing much taller
than the expected 7 points
@sgschantz
Copy link
Contributor Author

Now updated to so that the three-color stripe is a thin band 7 points in height.
It was apparently incorrect when running under Sonoma or later due to the Sonoma change in macOS where the default setting in UIView for (the formerly internal value) clipsToBounds changed from true to false.

Here is the updated appearance:

Pasted Graphic

@mcdurdin
Copy link
Member

mcdurdin commented Dec 5, 2024

Here is the updated appearance:

That looks great, thanks!

@dinakaranr
Copy link

Test Results

I tested this issue with the attached "Keyman 18.0.151-alpha-local" build on macOS Sonoma 14.5. 

  • TEST_ABOUT_WITH_SIL_LOGO (Passed):
  1. Install the "Keyman 18.0.151-alpha-local" build.
  2. Installed the "Khmer" & "Tamil99" keyboards.(e.g., IPA SIL)
  3. Select the "Khmer" keyboard.
  4. Open the "About" window by clicking the keyman icon.
  5. Verified the keyman logo appears as per the design doc. 
  6. Verified the Keyman logo has a white background on the header. 
  7. Verified the keyman links and buttons work on the About window.
    It works well. Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Dec 5, 2024
@sgschantz sgschantz merged commit 5081cfe into master Dec 6, 2024
5 checks passed
@sgschantz sgschantz deleted the chore/mac/12159-update-logo branch December 6, 2024 02:01
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.154-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

chore(mac): Update SIL logo on Keyman for macOS
5 participants