-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge master into kmc-convert 😎 #12778
Merged
mcdurdin
merged 190 commits into
epic/kmc-convert
from
chore/merge-master-into-kmc-convert
Dec 5, 2024
Merged
chore: merge master into kmc-convert 😎 #12778
mcdurdin
merged 190 commits into
epic/kmc-convert
from
chore/merge-master-into-kmc-convert
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odifiers and modifier(s) and key
…ection cannot be reached
…r CI The --full-test parameter in kmcmplib build.sh has not been working. This PR reconnects the parameter and also enables it by default for CI test builds (not release builds). Fixes: #12623
While kmc did this already in its callbacks, the unit test callbacks did not, which meant that some keyboard tests failed on Linux and macOS. Relates-to: #12623
…hitespace management On mac arch build, kmcmplib is failing to trim U+2002, unlike all other platforms. Using UTF-8 locale should treat the ISO 30112 POSIX space characters, which includes U+2002, as whitespace.
anii.kmn and sil_kmhmu.kmn both have mismatching case in filename references for icons. For now, we will disable tests for these two keyboards, so that tests pass on Linux (which has case-sensitive filesystem). Note: the filename case was already addressed in the keyboards repo, so when we realign to a more recent commit for the test fixtures, we should be able to include these tests again. Relates-to: #12623
…mcets, fv_nuucaanul
…ect-whitespace-handling-in-virtual-keys
Relates-to: #12641
auto: increment master version to 18.0.139
…xt-link fix(windows): help links updated
auto: increment master version to 18.0.140
…-332 chore(common): Add 17.0.330 - 17.0.332 to version history
…t-in-kmcmplib fix(developer): reconnect `--full-test` in kmcmplib build and enable for CI
The package subfile description field is never really used in the end-user apps. As it is meaningless metadata, we'll make it fully optional, and start to remove all references in the designers and compilers. TODO: For packages targeting Keyman 18.0+, we should consider removing the description field altogether from the subfiles.
If a .kps file had an `<Info>` element without a URL attribute, it would not map correctly in all circumstances. This change ensures that the kps-file-reader is responsible for normalizing the layout of these elements on read.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
chore: merge master into kmc-convert
chore: merge master into kmc-convert 😎
Dec 5, 2024
github-actions
bot
added
web/
windows/
android/
developer/
mac/
linux/
common/
developer/compilers/
common/resources/
Build infrastructure
oem/
linux/config/
linux/engine/
core/
Keyman Core
common/web/
common/models/templates/
common/models/wordbreakers/
developer/ide/
oem/fv/
oem/fv/android/
windows/engine/
docs
android/samples/
chore
labels
Dec 5, 2024
ermshiperete
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
android/samples/
android/
chore
common/models/templates/
common/models/wordbreakers/
common/resources/
Build infrastructure
common/web/
common/
core/
Keyman Core
developer/compilers/
developer/ide/
developer/
docs
epic-kmc-convert
linux/config/
linux/engine/
linux/
mac/
oem/fv/android/
oem/fv/
oem/
web/
windows/engine/
windows/
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip