chore: merge master into shared-fonts 🐻 #12782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change rename the test files in Common according to the discussion at the Keyman conference in November 2024.
… neither NFC nor NFD Fixes: #7394
- common: shift the 'strs' processing slightly, because otherwise we normalize to NFD before even tracking the strings - if any string is neither NFC nor NFD, give a warning - add tests for the same Fixes: #7394
Co-authored-by: Marc Durdin <[email protected]>
… review comments - report a warning on each separate instance of a denormalized string (once per string). Fixes: #7394
Addresses code review comment.
…hint-for-non-matching-script fix(developer): honour provided script when checking for matching scripts
chore(common): rename test files
This change renames a new test file and moves it to the new location. This file was overlooked in #12709.
fix(common): rename test file
auto: increment master version to 18.0.153
…94-verify-normalization-epic-ldml
…ormalization-epic-ldml feat(developer,common): verify normalization of strings 🙀
chore(core): Add link to Keyman Glossary 🎄
keyman-server
requested review from
mcdurdin,
darcywong00,
SabineSIL,
markcsinclair,
srl295,
jahorton and
rc-swag
as code owners
github-actions
bot
added
developer/
common/
developer/compilers/
core/
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
mcdurdin
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip