fix(linux): work around Lintian errors 🍒 🏠 #12817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only use a C API, so we can safely ignore all C++ symbols that show up in the symbols file. Those come from std template instantiations. Fixes: #12051
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
keymanapp-test-bot
bot
changed the title
github-actions
bot
added
linux/
linux/config/
linux/engine/
cherry-pick
ermshiperete
force-pushed
the
fix/linux/cherry-pick/12051_LintianErrors
branch
from
c71ff9e to
d67589d
Compare
|
We can ignore the failing API Verification - it fails because changing the .symbols file is part of the fix. This didn't really change the API, just the pattern that matches the C++ symbols to ignore, so we should ignore the check failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use a C API, so we can safely ignore all C++ symbols that show up in the symbols file. Those come from std template instantiations.
Also update AppStream metadata and change SIL International to SIL Global.
Additionally update the changelog file with the recent changes. Note that this uses a bogus version number that is smaller than the current release. This is because as part of the packaging process we set the version number. This only works if existing entries have a lower version number. Because the top entry has the status UNRELEASED it will be merged with the new entry.
Fixes: #12051
Cherry-pick: #12815
@keymanapp-test-bot skip