Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linux): pushing of updated changelog branch #12818

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

ermshiperete
Copy link
Contributor

@ermshiperete ermshiperete commented Dec 10, 2024

This fixes the upload-to-debian.sh script if the chore/linux/changelog branch was created a while back while the base branch moved in the meantime. In this case we have to use --force instead of --force-with-lease otherwise git gets confused. This is safe to do since the intention is that we replace the previous commit and we know that there is (should be) only one commit on the chore/linux/changelog branch.

@keymanapp-test-bot skip

This fixes the `upload-to-debian.sh` script if the `chore/linux/changelog`
branch was created a while back while the base branch moved in the
meantime. In this case we have to use `--force` instead of
`--force-with-lease` otherwise `git` gets confused. This is save to do
since the intention is that we replace the previous commit and we know
that there is (should be) only one commit on the `chore/linux/changelog`
branch.
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 10, 2024

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Can you add some documentation comments in the .sh ? (on the 🍒 pick PR too)

According to a comment on the latest upload to mentors.debian.org we
don't have to add the line "Re-release to Debian", so this change
removes this.
This change removes lines that sneaked in through a previous merge that
caused conflicts. The `changelog` on `master` should be idential to the
one in the stable branch.
@ermshiperete ermshiperete merged commit a14c200 into master Dec 11, 2024
8 checks passed
@ermshiperete ermshiperete deleted the fix/linux/uploadDebian branch December 11, 2024 09:22
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.158-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants