Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): expose km_core_keyboard_load_from_blob to WASM 🎼 #12822

Merged
merged 5 commits into from
Dec 17, 2024
Merged

feat(core): expose km_core_keyboard_load_from_blob to WASM 🎼 #12822

merged 5 commits into from
Dec 17, 2024

Conversation

ermshiperete
Copy link
Contributor

@ermshiperete ermshiperete commented Dec 11, 2024 •
edited
Loading

Also rename type library from km-core-interface.d.ts to keymancore.d.ts to match the name of the target (keymancore) to make it more obvious where this comes from and where/how it gets build.

Part-of: #11293
@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 11, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@github-actions github-actions bot added the core/ Keyman Core label Dec 11, 2024
@github-actions github-actions bot added the feat label Dec 11, 2024
@keymanapp-test-bot keymanapp-test-bot bot changed the title feat(core): expose km_core_keyboard_load_from_blob to WASM feat(core): expose km_core_keyboard_load_from_blob to WASM 🎼 Dec 11, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S17 milestone Dec 11, 2024
srl295
srl295 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@ermshiperete ermshiperete marked this pull request as draft December 11, 2024 18:47
@ermshiperete
chore(core): cleanup meson.build
067c8a0
@ermshiperete
fix(core): fix build of unit tests
193dd77 
Without this change building unit tests fail with an error that
`--shared-memory` is disallowed.
@ermshiperete
feat(core): properly implement converting blob
06a8c7a
@ermshiperete ermshiperete force-pushed the feat/core/exportapiwasmcore branch from 0a27bd4 to 06a8c7a Compare December 16, 2024 16:31
@ermshiperete
chore(web): rename type library to match target name
d48acd3 
This change renames the type library from `km-core=-interface.d.ts`
to `keymancore.d.ts` to match the name of the target (`keymancore`)
to make it more obvious where this comes from and where/how it gets
build.
@github-actions github-actions bot added the web/ label Dec 16, 2024
@ermshiperete ermshiperete marked this pull request as ready for review December 16, 2024 17:32
rc-swag
rc-swag approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ermshiperete ermshiperete merged commit 5dfa27b into epic/web-core Dec 17, 2024
23 of 24 checks passed
@ermshiperete ermshiperete deleted the feat/core/exportapiwasmcore branch December 17, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rc-swag rc-swag rc-swag approved these changes

@mcdurdin mcdurdin mcdurdin approved these changes

@srl295 srl295 srl295 approved these changes

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

Assignees
No one assigned
Labels
core/ Keyman Core epic-web-core feat web/
Projects
Keyman
Archived in project
Milestone
A18S17
Development

Successfully merging this pull request may close these issues.
4 participants
@ermshiperete @srl295 @mcdurdin @rc-swag