feat(web): load .kmx keyboard from blob 🎼 #12823
Draft
+82
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermshiperete
requested review from
jahorton,
mcdurdin,
rc-swag and
srl295
as code owners
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
mcdurdin
approved these changes
Dec 12, 2024
| } | ||
| }); | ||
| } catch (e: any) { | ||
| console.log('got execption in CoreFactory.createCoreProcessor', e); |
There was a problem hiding this comment.
Suggested change
| console.log('got execption in CoreFactory.createCoreProcessor', e); | |
| console.log('got exception in CoreFactory.createCoreProcessor', e); |
There was a problem hiding this comment.
I think we need to ensure that exceptions here aren't masked. Console log is not available in many contexts e.g. System keyboard. Console.error is a start but not enough maybe?
This change adds the web side of loading a .kmx keyboard from a blob. It also replaces the `CoreProcessor` class with `CoreFactory` that allows to directly use the methods defined in WASM without having to add another wrapper for each method.
ermshiperete
force-pushed
the
feat/web/loadkmx
branch
from
3c32fda to
11cfb2e
Compare
Base automatically changed from
feat/core/exportapiwasmcore
to
epic/web-core
December 17, 2024 07:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the web side of loading a .kmx keyboard from a blob. It also replaces the
CoreProcessorclass withCoreFactorythat allows to directly use the methods defined in WASM without having to add another wrapper for each method.Note that this is only the first step that implements loading the kmx keyboard, but we don't anything with it yet.
Part-of: #11293
@keymanapp-test-bot skip