fix(android/app): Toggle keyboard update notifications for landscape and tablets #7832

darcywong00 · 2022-11-28T07:45:11Z

Previously, the Keyman notification of keyboard updates could appear on 3 form factors:

phone (portrait orientation) - notification on overflow menu
phone (landscape orientation) - notification on menu
tablet (> 600dp, either orientation) - notification on menu

The landscape and tablet layouts had a complexity of a dynamic layout "update_count_view" which turned out to be un-clickable.

This PR removes the usage of "update_count_view", and toggles the update icon when updates are available. (This removes the feature of a dynamic count of updates available). The minor loss in feature should be acceptable since long-term we plan to just automatically download keyboard/dictionary updates as they're available (#7171).

User Testing

Setup - For each group, use the Android device and orientation as specified in the test.

On the device, download the old version 1.0 of sil_nko Keyman keyboard
Install the PR build of Keyman for Android

GROUP_PHONE_PORTRAIT - Verifies update installs for phone in portrait orientation
GROUP_PHONE_LANDSCAPE - Verifies update installs for phone in landscape orientation. Note - Keyman always starts up in portrait orientation, so you may need to re-orient the device back and forth to get Keyman in landscape orientation
GROUP_TABLET_LANDSCAPE - Verifies update installs for tablet (either orientation)

TEST_KEYBOARD_UPDATE

Launch Keyman for Android and dismiss the "Get Started" menu
From the Keyman settings menu, install the version 1.0 of the sil_nko keyboard package (Install from local file).
During installation of sil_nko, choose "Mandingo" language
When sil_nko finishes installing, completely exit Keyman
Relaunch Keyman for Android
After a while, see if notifications appear about keyboard updates being available. If they don't appear, completely exit Keyman and try re-launching Keyman for Android.
When there's notifications about Keyman updates being available, click the appropriate menu to "Install Updates"
- phone portrait - icon from the overflow menu
- phone landscape - icon on the top menu next to "Settings"
- tablet - icon on the top menu next to "Settings"
Verify Keyman prompts confirmation to download a keyboard update for sil_nko
Accept the dialog
Verify after a while, the keyboard updates in the background.
Long-press the globe key to display the keyboard picker menu.
Verify the version of sil_nko is now 1.1.

keymanapp-test-bot · 2022-11-28T07:45:37Z

User Test Results

Test specification and instructions

✅ GROUP_PHONE_PORTRAIT: - Verifies update installs for phone in portrait orientation
1 tests PASSED
- ✅ TEST_KEYBOARD_UPDATE (PASSED): Verified Update Install option for phone in portrait orientation and it is working as expected. (notes)
✅ GROUP_PHONE_LANDSCAPE: - Verifies update installs for phone in landscape orientation. Note - Keyman always starts up in portrait orientation, so you may need to re-orient the device back and forth to get Keyman in landscape orientation
1 tests PASSED
- ✅ TEST_KEYBOARD_UPDATE (PASSED): Tested this in my Android Mobile device Ver 11.0 with the attached PR build and here is my observation: 1. Verified the Install Updates for phone in landscape orientation and it seems to be working as expected. (notes)
✅ GROUP_TABLET_LANDSCAPE: - Verifies update installs for tablet (either orientation)
1 tests PASSED
- ✅ TEST_KEYBOARD_UPDATE (PASSED): Retested this in API 30 / Android 11.0 emulator (as per Darcy's suggestion) and here is my observation: 1. Tested this in Landscape orientation. 2. Not able to see the 'Install Update' option near the Settings option. 3. However, I noticed this option is available in the Keyboard menu. 4. By clicking on this would update the Keyboard version from 1.0 to 1.1. Note: In the Portrait orientation, I was able to see the 'Install Update' button near Settings button. (notes)

Test Artifacts

Android

bharanidharanj · 2022-11-28T12:21:59Z

GROUP_PHONE_PORTRAIT: - Verifies update installs for phone in portrait orientation

TEST_KEYBOARD_UPDATE (PASSED): Verified Update Install option for phone in portrait orientation and it is working as expected.

bharanidharanj · 2022-11-28T12:36:49Z

GROUP_PHONE_LANDSCAPE: - Verifies update installs for phone in landscape orientation. Note - Keyman always starts up in portrait orientation, so you may need to re-orient the device back and forth to get Keyman in landscape orientation

TEST_KEYBOARD_UPDATE (PASSED): Tested this in my Android Mobile device Ver 11.0 with the attached PR build and here is my observation: 1. Verified the Install Updates for phone in landscape orientation and it seems to be working as expected.

bharanidharanj · 2022-11-28T13:55:36Z

Test Results

GROUP_TABLET_LANDSCAPE: - Verifies update installs for tablet (either orientation)

TEST_KEYBOARD_UPDATE (FAILED): Tested with the attached PR build in API 31 / Android 12.0 emulator and here is my observation: 1. After clicking the Install Updates icon from the Language menu, there was a confirmation dialog appeared on the Screen. 2. Clicking the Confirmation dialog leads to crash Keyman application.

darcywong00 · 2022-11-29T01:39:42Z

@bharanidharanj - the crash you experienced was related to Android S, and I've created issue #7843 to address that.

Can you retest with Android tablet using Android 11.0 (API 30)?

@keymanapp-test-bot retest GROUP_TABLET_LANDSCAPE

bharanidharanj · 2022-11-29T06:20:58Z

@bharanidharanj - the crash you experienced was related to Android S, and I've created issue #7843 to address that.

Can you retest with Android tablet using Android 11.0 (API 30)?

@keymanapp-test-bot retest GROUP_TABLET_LANDSCAPE

@darcywong00 Sure, I will retest it in Android 11.0 emulator.

mcdurdin · 2022-11-29T06:51:35Z

android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/MainActivity.java

@@ -452,6 +453,11 @@ public boolean onOptionsItemSelected(MenuItem item) {
        KMManager.getUpdateTool().executeOpenUpdates();
        // Dismiss icon
        updateUpdateCountIndicator(0);
+        final MenuItem _keyboardupdate = menu.findItem(R.id.action_update_keyboards);


Is it possible for menu to be uninitialized at this point?

The system should have called onCreateOptionsMenu() the first time menu is displayed

https://developer.android.com/reference/android/app/Activity#onCreateOptionsMenu(android.view.Menu)

bharanidharanj · 2022-11-29T07:43:58Z

GROUP_TABLET_LANDSCAPE: - Verifies update installs for tablet (either orientation)

TEST_KEYBOARD_UPDATE (PASSED): Retested this in API 30 / Android 11.0 emulator (as per Darcy's suggestion) and here is my observation: 1. Tested this in Landscape orientation. 2. Not able to see the 'Install Update' option near the Settings option. 3. However, I noticed this option is available in the Keyboard menu. 4. By clicking on this would update the Keyboard version from 1.0 to 1.1. Note: In the Portrait orientation, I was able to see the 'Install Update' button near Settings button.

..Landscape Orientation

..Portrait Orientation

keyman-server · 2022-11-30T18:01:58Z

Changes in this pull request will be available for download in Keyman version 16.0.116-beta

fix(android/app): Toggle keyboard update notification

adaaa3d

darcywong00 requested a review from mcdurdin as a code owner November 28, 2022 07:45

darcywong00 added this to the A17S1 milestone Nov 28, 2022

github-actions bot added android/ android/app/ fix labels Nov 28, 2022

keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Nov 28, 2022

keymanapp-test-bot bot added user-test-failed and removed user-test-required User tests have not been completed labels Nov 28, 2022

sentry-io bot mentioned this pull request Nov 29, 2022

bug(android/engine): Download intent requires FLAG_IMMUTABLE for Android S+ #7843

Closed

keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Nov 29, 2022

darcywong00 mentioned this pull request Nov 29, 2022

fix(android/engine): Use FLAG_IMMUTABLE for PendingIntent for Android S+ #7844

Merged

darcywong00 linked an issue Nov 29, 2022 that may be closed by this pull request

bug(android): "update pending" icon on tablets is not responsive #6731

Closed

mcdurdin approved these changes Nov 29, 2022

View reviewed changes

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Nov 29, 2022

darcywong00 merged commit e78f5fd into beta Nov 30, 2022

darcywong00 deleted the fix/android/tablet-keyboard-update branch November 30, 2022 01:33

darcywong00 mentioned this pull request Nov 30, 2022

bug(android): "update pending" icon on tablets is not responsive #6731

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(android/app): Toggle keyboard update notifications for landscape and tablets #7832

fix(android/app): Toggle keyboard update notifications for landscape and tablets #7832

darcywong00 commented Nov 28, 2022 •

edited

Loading

keymanapp-test-bot bot commented Nov 28, 2022 •

edited

Loading

bharanidharanj commented Nov 28, 2022

bharanidharanj commented Nov 28, 2022

bharanidharanj commented Nov 28, 2022

darcywong00 commented Nov 29, 2022

bharanidharanj commented Nov 29, 2022

mcdurdin Nov 29, 2022

darcywong00 Nov 29, 2022

bharanidharanj commented Nov 29, 2022

keyman-server commented Nov 30, 2022

fix(android/app): Toggle keyboard update notifications for landscape and tablets #7832

fix(android/app): Toggle keyboard update notifications for landscape and tablets #7832

Conversation

darcywong00 commented Nov 28, 2022 • edited Loading

User Testing

keymanapp-test-bot bot commented Nov 28, 2022 • edited Loading

User Test Results

Test Artifacts

bharanidharanj commented Nov 28, 2022

GROUP_PHONE_PORTRAIT: - Verifies update installs for phone in portrait orientation

bharanidharanj commented Nov 28, 2022

GROUP_PHONE_LANDSCAPE: - Verifies update installs for phone in landscape orientation. Note - Keyman always starts up in portrait orientation, so you may need to re-orient the device back and forth to get Keyman in landscape orientation

bharanidharanj commented Nov 28, 2022

Test Results

GROUP_TABLET_LANDSCAPE: - Verifies update installs for tablet (either orientation)

darcywong00 commented Nov 29, 2022

bharanidharanj commented Nov 29, 2022

mcdurdin Nov 29, 2022

Choose a reason for hiding this comment

darcywong00 Nov 29, 2022

Choose a reason for hiding this comment

bharanidharanj commented Nov 29, 2022

GROUP_TABLET_LANDSCAPE: - Verifies update installs for tablet (either orientation)

keyman-server commented Nov 30, 2022

darcywong00 commented Nov 28, 2022 •

edited

Loading

keymanapp-test-bot bot commented Nov 28, 2022 •

edited

Loading