-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epic: windows-upgrades 📲 #9330
Closed
Closed
epic: windows-upgrades 📲 #9330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change means the main keyman32.dll will now include the version number as part of its name. Then next step will be to add proxy keyman32.dll which will be needed for imx callback and will catch any legacy debug applications etc which have the keyman32.dll name hard coded.
Use the windows registry to store the name for the versioned keyman32??.dll and the keyman64??.dll. LoadLibrary calls have been updated to read the name to load from the registry value.
Co-authored-by: Marc Durdin <[email protected]>
Co-authored-by: Marc Durdin <[email protected]>
…windows-upgrades chore(windows): merge master into epic windows upgrades (A17S19) 📲
…windows-upgrades chore(windows): Merge master into epic/windows-upgrades for sprint A17S21 📲
…ws-upgrades chore: merge master into windows-upgrades 📲
…nto-windows-upgrades
…ws-upgrades chore: merge master into windows-upgrades 📲
…pg-cert chore(windows): merge master epic win upg cert 📲
…nto-windows-upgrades
…ws-upgrades chore: merge master into windows-upgrades 📲
…ws-upgrades chore: merge master into windows-upgrades
22 tasks
Abandoned this branch in favour of epic/windows-updates (#10041) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
common/
epic
A long lived branch, home for a new feature, usually will have child PRs based on it
epic-windows-upgrades
windows/engine/
windows/
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip
Deprecated
Epic PR is: #9330
For now versioned dlls has been parked. It may be revisited again in the future.
[x] feat(windows): create versioned and proxy dlls for keyman32 and keyman64 📲 #9202[x] feat(windows): background install and cache - windows scheduler 📲 #9333