Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): drop \u1234 format 🙀 #9560

Merged
merged 7 commits into from
Sep 19, 2023
Merged

feat(core): drop \u1234 format 🙀 #9560

merged 7 commits into from
Sep 19, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 14, 2023 •
edited
Loading

This does not complete #9515 - there are other unescaping situations to consider. But it will unbreak kmc being able to compile current ldml

@keymanapp-test-bot skip

@srl295
chore(resources): ldml update (CLDR v44 alpha 2) 🙀
0265680 
- unicode-org/cldr:61b74a36de8329daed152005133a699ae7f2012b
- for feat(core): ldml drop \u1234 format 🙀  #9515
@srl295 srl295 self-assigned this Sep 14, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Sep 14, 2023 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S21 milestone Sep 14, 2023
@srl295 srl295 changed the title chore(resources): ldml update (CLDR v44 alpha 2) 🙀 feat(core): drop \u1234 format 🙀 Sep 14, 2023
@srl295 srl295 marked this pull request as ready for review September 14, 2023 08:14
@srl295 srl295 marked this pull request as draft September 14, 2023 08:15
@mcdurdin mcdurdin modified the milestones: A17S21, A17S22 Sep 15, 2023
@srl295
chore(developer): ldml fix for update 🙀
28012d1 
- hardware types isn't a fixed set anymore
- un-mothball the pertinent error type

Related to #9403, exposed during #9515 CLDR update
@srl295
fix(developer): ldml drop \u1234 🙀
213dd7d 
- for now, convert \u{1234} to \u1234 before going into
UnicodeSet.

- for feat(core): ldml drop \u1234 format 🙀  #9515
@srl295
fix(developer): ldml drop \u1234 🙀
2560171 
- temporarily roll back change to test.xml

- for feat(core): ldml drop \u1234 format 🙀  #9515
@srl295 srl295 marked this pull request as ready for review September 15, 2023 18:53
@srl295 srl295 requested a review from darcywong00 as a code owner September 15, 2023 18:53
mcdurdin
mcdurdin approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But won't unblock kmc until the Windows codesigning certificate situation is resolved, because publishing to npm happens after all parts of build succeed. Hopefully very soon now.

@srl295
fix(developer): ldml drop \u1234 🙀
2750857 
- fix 1..6 char Unicode escapes with an unrolled loop

- for feat(core): ldml drop \u1234 format 🙀  #9515
@srl295
Copy link
Member Author

srl295 commented Sep 15, 2023

@mcdurdin now supports all other widths of \u{...}

@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Sep 18, 2023
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Sep 18, 2023
@github-actions github-actions bot added core/ Keyman Core and removed core/ Keyman Core labels Sep 18, 2023
@srl295 srl295 merged commit 760a578 into master Sep 19, 2023
@srl295 srl295 deleted the feat/developer/9515-drop-u1234-epic-ldml branch September 19, 2023 14:26
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.176-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

Assignees

@srl295 srl295

Labels
chore common/resources/ Build infrastructure common/ core/ Keyman Core developer/compilers/ developer/ epic-ldml feat
Projects
None yet
Milestone
A17S22
Development

Successfully merging this pull request may close these issues.
3 participants
@srl295 @keyman-server @mcdurdin