refactor(linux): Simplify adding keyboard #9734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
force-pushed
the
refactor/linux/simplifyaddkbd
branch
from
02fdf58 to
5536381
Compare
Before we add a keyboard we check if we already added this keyboard (in a different area). If we did (with the same or newer version) we skip this keyboard. This change now immediately returns whereas previously we set a flag and then didn't execute the rest of the method.
ermshiperete
force-pushed
the
refactor/linux/simplifyaddkbd
branch
from
5536381 to
7bab603
Compare
|
Changes in this pull request will be available for download in Keyman version 17.0.189-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we add a keyboard we check if we already added this keyboard (in a different area). If we did (with the same or newer version) we skip this keyboard. This change now immediately returns whereas previously we set a flag and then didn't execute the rest of the method.
@keymanapp-test-bot skip