chore: merge master into package-metadata #9736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a regex form that matches any marker For: #9119
- reenable some tests For: #9119
- refactor string preprocessing pipeline into an options bag
Fixes #9692. Signature checking was skipped because we missed a ".virtual" to force nmake to build the test and test_i3633 targets. This opened up a small cascade of related formatting issues on Makefiles, and the fact that the test_i3633 (has there ever been a more poorly named project?) Makefile did not even work. Refactored significantly, added same tests to Developer Makefile, and also now verifying the .msi and installer executable. We can improve this further but I'd like to get this in to avoid further critical issues with code signing given the current broken signing configuration.
Usually this is done automatically. However, if e.g. no `DISPLAY` variable is set it'll fail. When we explicitly initialize GTK it still fails, but shows a more helpful warning instead of throwing a runtime error. Fixes #9705.
- cleaned up regex For: #9119
…-ldml feat(developer): ldml fix all remaining TODOs around markers and variables 🙀
…gnature-check fix(windows): re-enable signature check 🔥
Fixes #9721. Also tweaks some documentation references to keyboardprocessor, but does not touch those relating to debian/control.
The `hash` method that we previously used calculates the hash based on the memory location, i.e. with each program run we get a different value for the same user. This change now uses the md5 algorithm so that the same user always produces the same hash.
This change adds additional details to Sentry events so that the "All Events" tab on keyman.sentry.io will show helpful values in the "device" and "os" columns instead of emptry strings.
…rdprocessor.h-to-keyman_core_api.h chore(core): rename keyboardprocessor.h to keyman_core_api.h
…_-to_km_core_ chore: rename km_kbp_ to km_core_
Two conflicting merges meant that paths diverged. Fixes that.
…paths-post-merge chore(developer): fixup signcode paths for server
fix(linux): Explicitly initialize GTK
chore(linux): Improve Sentry reports
keyman-server
requested review from
rc-swag,
ermshiperete,
mcdurdin,
jahorton and
darcywong00
as code owners
github-actions
bot
added
windows/
developer/
linux/
common/
developer/compilers/
common/resources/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip