fix(linux): Fix crash initializing Sentry with Python < 3.10 #9774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu 20.04 comes with Python 3.8 which doesn't have `platform.freedesktop_os_release()`. This change catches the exception if this happens, as well as other exceptions we might get so that the initialization of Sentry will succeed. Fixes #9773.
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions
Test Artifacts
|
mcdurdin
approved these changes
Oct 16, 2023
Test Results
|
keymanapp-test-bot
bot
removed
the
user-test-required
|
Changes in this pull request will be available for download in Keyman version 17.0.193-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 20.04 comes with Python 3.8 which doesn't have
platform.freedesktop_os_release(). This change catches the exception if this happens, as well as other exceptions we might get so that the initialization of Sentry will succeed.Fixes #9773.
User Testing
Preparations
The tests should be run on Wasta 20.04 or Ubuntu 20.04.
Install build artifacts of this PR
Reboot
Tests
TEST_CAN_START: Open a terminal window and run
km-config. Verify that Keyman Configuration starts.