-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make keystone_example_app working #1
Open
dayeol
wants to merge
15
commits into
dayeol/packaging
Choose a base branch
from
keystone-example-app
base: dayeol/packaging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenyp67
force-pushed
the
dayeol/packaging
branch
2 times, most recently
from
June 25, 2023 23:42
14a6aaf
to
b851314
Compare
… APIs and in code This commit renames stuff like 'cca', 'CCA' in various Islet APIs and interfaces, and code-dir / artifact-names to become 'islet' or ISLET, as appropriate. This naming is inline with what was done for Keystone-based simple-app. There are just a couple of remaining instances of cca, only used for shim-produced 'bins', in the driver shell script. Deleted file src/certifier.proto had crept back in. Delete it again.
…r repo. Add CI-checks This commit does a one-time apply of default 'gofmt' formatting to all .go files in the Certifier repo. To prevent future divergence, a new CI/scripts/check-gofmt.sh script is added, which gets invoked in early steps of build.yml . CI-builds will fail if any gofmt violations are seen.
…iles This commit cleans up docs related to simple_app_under_keystone and simple_app_under_islet: - Adds islet/instructions.md; - Fixes sample-app README.md to list 2 new sample-apps - renames temporary_instructions.txt to runnable 'script' - Other misc edits, corrections
…rtifier-framework-for-confidential-computing into keystone-example-app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacked PR on top of ccc-certifier-framework#102
cc @evgenyp67