Enclave Memory Sharing + Enclave Mailbox #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
dayeol
reviewed
Oct 13, 2020
| } | ||
| } | ||
|
|
||
| if(enclave_addr) |
There was a problem hiding this comment.
can you use mprv instead of passing physical address to this SBI?
with mprv, you can pass in the runtime's virtual address and the SM will use satp to translate the VA.
dayeol
reviewed
Oct 13, 2020
| } | ||
|
|
||
|
|
||
| uintptr_t mcall_sm_mem_share(size_t uid, uintptr_t enclave_addr, uintptr_t enclave_size){ |
There was a problem hiding this comment.
Can you change the mem_share and mem_stop to mem_share_start and mem_share_stop?
dayeol
requested changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding enclave sharing and enclave mailbox functionality to the SM.