"Fix" sym_resolve in python bindings

[wsxarcher]

#271

[aquynh]

oh now i see that this interface does not look good. would be simpler for user to return the value, rather than set the content value like this.

the reason is that this resolver must return bool value to indicate if it sets the symbol. perhaps we should change the API a bit: this function either returns symbol value, or None when it does not care. so the function above will be changed to be:

    def sym_resolver(symbol):
        # is this the missing symbol we want to handle?
        if symbol == "_l1":
            # we handled this symbol, so return symbol value
            return 0x1002

        # we did not handle this symbol, so return None
        return None

what do you think?

[wsxarcher]

It looks simpler to the end user but the C API should be changed... And what about dealing with the symbols resolved 0 in the C? Another problem

[wsxarcher]

It can be a problem if the bindings must respect the C API, but of course it can differ.

[aquynh]

we need a wrapper for this.

btw, with this PR applied, suite/regress/x64_sym_resolver.py still does not pass yet, right?

[wsxarcher]

You can also use [] but maybe it's less explicit I think

def sym_resolver(symbol, value):
        # is this the missing symbol we want to handle?
        if symbol == "_l1":
            # we handled this symbol, so return symbol value
            value[0] = 0x1002
            return True

        # we did not handle this symbol, so return None
        return None

Yes, x64_sym_resolver.py still not pass.

[wsxarcher]

The fix does not work at all.
sample.py works because jump relative symbol are not resolved by sym_resolve, so it is not called in any way.

[wsxarcher]

(because in that case is calculated by the starting point + instruction length)

[aquynh]

i just fixed Python binding in the "test" branch, so sample.py works now. but your x86_call_ptr_sym.py still fails for some unknown reason ...

[wsxarcher]

Maybe call is resolved differently from jmp? What about suite/regress/x64_sym_resolver.py ?

[aquynh]

there is a bug in the core for that testcase. will see how to fix that.