DNM: Poc rustformations sidebyside #10677
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made tilt work again. try it! ``` ctlptl create cluster kind --name kind-kgateway --registry=ctlptl-registry VERSION=1.0.0-ci1 CLUSTER_NAME=kgateway IMAGE_VARIANT=standard make kind-build-and-load tilt up ``` also made tcprotues a delayed informer so we will start if they are not there.
yuval-k
reviewed
Feb 27, 2025
|
|
||
| for (key, value) in &self.request_headers_setter { | ||
| let mut env = self.env.clone(); | ||
| env.add_template("temp", value).unwrap(); |
There was a problem hiding this comment.
add_template can fail so ideally we want to do it at config time so envoy NACKs it.. do you know if that's possible?
yuval-k
reviewed
Feb 27, 2025
| }; | ||
| let value = std::str::from_utf8(val.as_slice()).unwrap().to_string(); | ||
|
|
||
| headers.insert(key.to_string(), value); |
There was a problem hiding this comment.
we copy all the headers all the time? this could potentially have perf issues; current impl only copies the header when it is requested by user - is that achievable?
nfuden
added a commit
to nfuden/k8sgateway
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solely serves to illustrate how we could start migrating off of envoy-gloo into using purely envoyproxy/envoy builds while still being able to extend functionality that gloo users used heavily. This approach relies heavily on the new dynamic_modules examples (https://github.com/envoyproxy/dynamic-modules-examples/tree/main/rust)
In order to have old envoy-gloo functionality work side by side for best effect this also includes bumping envoy-gloo to be on an envoy version post 1.33 which has workable dynamic modules.
Note that this exists to be referenced in the upcoming EP where data plane changes will be proposed to promote vendor neutrality and therefore work to not rely on envoy-gloo repository.