*: Add support for AWS Lambda #10720
Conversation
Signed-off-by: timflannagan <[email protected]>
timflannagan
force-pushed
the
feat/lambda
branch
from
72ee5a4 to
763f63e
Compare
…iew comments Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
| // } | ||
| tlsContext := &envoyauth.UpstreamTlsContext{ | ||
| CommonTlsContext: nil, | ||
| // TODO(yuval-k): Add verification context |
There was a problem hiding this comment.
can we add back this TODO (or probably better is creating an issue for it)?
| out.ClusterDiscoveryType = &envoy_config_cluster_v3.Cluster_Type{ | ||
| Type: envoy_config_cluster_v3.Cluster_LOGICAL_DNS, | ||
| } | ||
| // TODO(yuval-k): why do we need to make sure we use ipv4 only dns? | ||
| // TODO(nfuden): Update to reasonable ipv6 https://aws.amazon.com/about-aws/whats-new/2021/12/aws-lambda-ipv6-endpoints-inbound-connections/ | ||
| out.DnsLookupFamily = envoy_config_cluster_v3.Cluster_V4_ONLY |
There was a problem hiding this comment.
should reevaluate this (see removed TODOs above); thoughts @yuval-k ?
There was a problem hiding this comment.
any idea on what the right value is here? out.DnsLookupFamily = envoy_config_cluster_v3.Cluster_AUTO?
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
|
are these relevant/still needed? https://github.com/kgateway-dev/kgateway/blob/main/internal/kgateway/extensions2/settings/settings.go#L10-L11 |
Signed-off-by: timflannagan <[email protected]>
|
Not in the current lambda plugin implementation. |
Signed-off-by: timflannagan <[email protected]>
@lgadban I'll look into this today some more. I need to read up on how the deployer handled this in the previous impl. |
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
…S family Signed-off-by: timflannagan <[email protected]>
Description
TODO: Add test case for istio auto-mtls edge case
TODO: Add PR description
Checklist: