Feat/transformation ep 10574 #10727

nfuden · 2025-03-03T03:59:49Z

Start building out the implementation for transformation EP 10574

In this PR we do 5 things:

Add basic Transformation API per EP 10574 and implement it with classic functionality
Add basic Rusformation POC which can be toggled and implements a subsection of the API
Simple e2e tests for Transformations per the current test setup.
Minor cleanup found during testing with kgateway suites
Reenable filter gen for auto registration of protobufs for go code consumption
Get golanglint-ci to run more cleanly locally

Note that Rustformations cannot graduate to a production ready stance until we get route level configuration cleaner in upstream

…gen to be autogenerated

…stformations

…aths

…ocalport

api/v1alpha1/route_policy_types.go

internal/envoyinit/ENVOY_VERSION

…omposite approach

… a make utility target

lgadban · 2025-03-05T04:06:53Z

internal/envoyinit/Dockerfile.envoyinit

+COPY --from=rust_builder /build/amd64_librust_module.so /usr/local/lib/librust_module.so
+
+
+# SDS-specific setup, only used if ENVOY_SIDECAR=true


assuming just copy/paste miss?

Taken from the existing setup as we have the go main file that has specific work to change things when in sds

internal/kgateway/extensions2/plugins/routepolicy/route_policy_plugin.go

internal/envoyinit/integration/main_test.go

internal/envoyinit/rustformations/target/debug/build/clang-sys-f9db6f527274df00/out/macros.rs

internal/envoyinit/integration/main_test.go

test/kubernetes/e2e/features/transformation/suite.go

…hed later if github does not detect this as a move

…ed for gw port forwarding

… adopted

nfuden · 2025-03-05T18:22:50Z

Split out envoyinit move here #10756

… will be tracking it in actual kube e2e tests

…p-10574

…xt needs to be rebuilt

nfuden added 4 commits February 25, 2025 14:26

pull over non-conflicts from kgateway-dev#10677

4b8563c

pull over non-conflicts from kgateway-dev#10677

f15055d

api/route_policy

a28928f

feat: first pass transform updates

77a702a

nfuden added the work in progress signals bulldozer to keep pr open (don't auto-merge) label Mar 3, 2025

nfuden marked this pull request as draft March 3, 2025 14:24

nfuden added 14 commits March 3, 2025 09:27

fix: cleanup and add rust ignores

358acf6

hack/generate: update hack script to call filter gen and refix filter…

65a0299

…gen to be autogenerated

Merge branch 'main' into feat/transformation-ep-10574

67aa851

.gitignore: revert .json adition

54dedc7

envoyinit/rustformation: allow for missing fields in rustformations

e30ce3a

plugins/routepolicy: transformation formatting cleanup

27ebc42

plugins/routepolicy: Continued cleanup of dead paths attempted for ru…

f4a8d87

…stformations

plugins/routepolicy: clean up the distinction in two transformation p…

32a5148

…aths

test/kubernetes/testutils: Update admin portforwarder to use random l…

78fb85f

…ocalport

pkg/utils: Update comments on portforwarder

1895c90

test/e2e: transformation kube e2e tests

16f3a57

Merge branch 'main' into feat/transformation-ep-10574

41e748f

envoyinit: remove unneded exemplar file

ad9d508

codegen

665c93c

yuval-k reviewed Mar 4, 2025

View reviewed changes

api/v1alpha1/route_policy_types.go Outdated Show resolved Hide resolved

yuval-k reviewed Mar 4, 2025

View reviewed changes

internal/envoyinit/ENVOY_VERSION Outdated Show resolved Hide resolved

nfuden added 8 commits March 4, 2025 11:47

revert pieces of bad main merge

669fe6a

codegen after reverting pieces from bad main merge

ebb4eed

whitespace revert merge of whitespace

65039b2

test/transformation: cleanup whitespaces and unused constructs from c…

471448e

…omposite approach

envoyinit: Cleanup readmes and add info for abi updates to readme and…

ecebc91

… a make utility target

Merge branch 'main' into feat/transformation-ep-10574

20aacc4

internal/routepolicy: update imports

3280918

internal/routepolicy: burn down go vet issues

7156aee

Merge branch 'main' into feat/transformation-ep-10574

6e3b7b2

nfuden enabled auto-merge March 4, 2025 20:56

lgadban reviewed Mar 5, 2025

View reviewed changes

yuval-k reviewed Mar 5, 2025

View reviewed changes

test/kubernetes/e2e/features/transformation/suite.go Outdated Show resolved Hide resolved

nfuden added 7 commits March 5, 2025 09:34

envoyinit: Complete the migration from cmd package. This may be squas…

787905e

…hed later if github does not detect this as a move

envoyinit: more cleanup of files

409b119

extensions/transform: cleaner rustformation switch

5a125e3

make: envoy cmd

5b63015

envoyinit: add rstformation attribution

8a2a15f

test/transformation: add rustformation test waits for dynamic modules

2c27785

test/transformation: update after local run to have deployment select…

ada5ac8

…ed for gw port forwarding

nfuden marked this pull request as draft March 5, 2025 16:09

auto-merge was automatically disabled March 5, 2025 16:09
Pull request was converted to draft

nfuden added 3 commits March 5, 2025 11:10

Merge branch 'main' into feat/transformation-ep-10574

3243a92

test/transformation: Add check to make sure dynamic modules have been…

813cf38

… adopted

Merge branch 'main' into feat/transformation-ep-10574

42b9918

nfuden mentioned this pull request Mar 5, 2025

cmd/envoyinit -> internal/envoyinit #10756

Merged

nfuden added 6 commits March 5, 2025 13:25

.goreleaser: update envoyinit location

f5a4247

Merge branch 'main' into feat/transformation-ep-10574

f948047

.goreleaser: cleanup paths

c2d5c0b

internal/settings: Make os env variable part of global settings

9efc3e9

internal/envoyinit: Remove the extra rustformations integration as we…

f871e88

… will be tracking it in actual kube e2e tests

internal/routepolicy: Equals updates to include more fields

7ab8a2c

nfuden marked this pull request as ready for review March 5, 2025 19:34

nfuden added 4 commits March 5, 2025 15:01

internal/routepolicy: cleanup

e854830

Merge remote-tracking branch 'origin/main' into feat/transformation-e…

f332a05

…p-10574

.goreleaser: Does not respect the same paths as make targets so conte…

a8b23b2

…xt needs to be rebuilt

Merge branch 'main' into feat/transformation-ep-10574

1c6b2cb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/transformation ep 10574 #10727

Feat/transformation ep 10574 #10727

nfuden commented Mar 3, 2025 •

edited

Loading

lgadban Mar 5, 2025

nfuden Mar 5, 2025

nfuden commented Mar 5, 2025

		COPY --from=rust_builder /build/amd64_librust_module.so /usr/local/lib/librust_module.so


		# SDS-specific setup, only used if ENVOY_SIDECAR=true

Feat/transformation ep 10574 #10727

Are you sure you want to change the base?

Feat/transformation ep 10574 #10727

Conversation

nfuden commented Mar 3, 2025 • edited Loading

lgadban Mar 5, 2025

Choose a reason for hiding this comment

nfuden Mar 5, 2025

Choose a reason for hiding this comment

nfuden commented Mar 5, 2025

nfuden commented Mar 3, 2025 •

edited

Loading