-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AI extproc server #10745
base: main
Are you sure you want to change the base?
Add AI extproc server #10745
Conversation
8c70222
to
960c855
Compare
960c855
to
6e1542e
Compare
Just a heads up that goreleaser doesn't support python (yet ™️ ). We'll need to release the ai-extension component with the rest of our container images in the release.yaml workflow. Can be done in a follow-up, but needs to be done before cutting beta1 imho. |
(I don't think multi-arch support is a hard requirement though.) |
@@ -1,5 +1,7 @@ | |||
kind: Cluster | |||
apiVersion: kind.x-k8s.io/v1alpha4 | |||
networking: | |||
ipFamily: dual # Enable IPv4 and IPv6 support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -126,11 +126,10 @@ gateway: | |||
aiExtension: | |||
enabled: false | |||
image: | |||
repository: gloo-ai-extension | |||
registry: quay.io/solo-io | |||
registry: ghcr.io/kgateway-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete ghcr.io/kgateway-dev
, use default from chart.
repository: gloo-ai-extension | ||
registry: quay.io/solo-io | ||
registry: ghcr.io/kgateway-dev | ||
repository: kgateway-ai-extension | ||
pullPolicy: IfNotPresent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove pull policy (inherit from Chart)
internal/ai-extension/.dockerignore
Outdated
@@ -0,0 +1 @@ | |||
__pycache__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timflannagan @lgadban Any thoughts on moving this outside of internal? We were thinking:
- Move dockerfile to cmd
- Move ai-extensions to a top level
python
directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question: I'm not sure what's best here. I think my preference is non-Go code doesn't live in the internal/ directory, but I just looked at the transformation PR, and we're adding rust code to the internal/envoyinit directory, so moving the AI extensions to a top-level directory could introduce some inconsistency in the codebase.
cf7c878
to
9c18d21
Compare
Description
Adds the extproc extension server to kgateway. Requires #10627 to merge in first to introduce plugin changes.
API changes
Depends on: #10493
Code changes
Plugin changes are in: #10627
CI changes
Introduces the AIExtensions e2e suite as a separate cluster for PRs and adds the tests to the nightlys.
TODO: need to setup github env:
Docs changes
Tracked in kgateway-dev/kgateway.dev#59
Context
Adds AI extension extproc to kgateway
Interesting decisions
N/A
Testing steps
Stream:
Prompt guard:
Apply example policy (regex on EMAIL)
Send request:
Vertex-AI example:
Notes for reviewers
Checklist: