*: Enable the prealloc linter #10762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timflannagan <[email protected]>
|
Related to #10496 |
jenshu
reviewed
Mar 6, 2025
| @@ -261,7 +261,7 @@ func convertHeaderModifier(kctx krt.HandlerContext, f *gwv1.HTTPHeaderFilter) fu | |||
| if f == nil { | |||
| return nil | |||
| } | |||
| var headersToAddd []*envoy_config_core_v3.HeaderValueOption | |||
| headersToAddd := make([]*envoy_config_core_v3.HeaderValueOption, 0, len(f.Add)+len(f.Set)) | |||
There was a problem hiding this comment.
Suggested change
| headersToAddd := make([]*envoy_config_core_v3.HeaderValueOption, 0, len(f.Add)+len(f.Set)) | |
| headersToAdd := make([]*envoy_config_core_v3.HeaderValueOption, 0, len(f.Add)+len(f.Set)) |
| @@ -294,7 +294,7 @@ func convertResponseHeaderModifier(kctx krt.HandlerContext, f *gwv1.HTTPHeaderFi | |||
| if f == nil { | |||
| return nil | |||
| } | |||
| var headersToAddd []*envoy_config_core_v3.HeaderValueOption | |||
| headersToAddd := make([]*envoy_config_core_v3.HeaderValueOption, 0, len(f.Add)+len(f.Set)) | |||
There was a problem hiding this comment.
Suggested change
| headersToAddd := make([]*envoy_config_core_v3.HeaderValueOption, 0, len(f.Add)+len(f.Set)) | |
| headersToAdd := make([]*envoy_config_core_v3.HeaderValueOption, 0, len(f.Add)+len(f.Set)) |
Comment on lines
+95
to
+96
| certs := make([][]byte, 0, len(s.secrets)) | ||
| items := make([]cache_types.Resource, 0, len(s.secrets)) |
There was a problem hiding this comment.
hmm, the cap should be higher, looks like you can append to certs up to 4 times within each iteration, and append to items twice each iteration
| @@ -51,7 +51,7 @@ func resourcesFromSnapshot(snap envoycache.ResourceSnapshot) (*EnvoyResources, e | |||
| // listenersFromSnapshot accepts a Snapshot and extracts from it a slice of pointers to | |||
| // the Listener structs contained in the Snapshot. | |||
| func listenersFromSnapshot(snap envoycache.ResourceSnapshot) ([]*envoy_config_listener_v3.Listener, error) { | |||
| var listeners []*envoy_config_listener_v3.Listener | |||
| listeners := make([]*envoy_config_listener_v3.Listener, 0, len(snap.GetResources(envoyresource.ListenerType))) | |||
There was a problem hiding this comment.
i don't know how expensive the snap.GetResources call is, but should we just call it once and set it as a variable? (same with the other instances below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables the https://golangci-lint.run/usage/linters/#prealloc linter. We're relying on the
simple: truedefault setting here. Any additional settings could overkill.Checklist: