Skip to content

Commit

Permalink
Remove deprecated configs kCastToIntByTruncate and `kCastStringToDa…
Browse files Browse the repository at this point in the history
…teIsIso8601` (facebookincubator#8352)

Summary:
After facebookincubator#7377, kCastToIntByTruncate and kCastStringToDateIsIso8601 are no longer in use.

Pull Request resolved: facebookincubator#8352

Reviewed By: mbasmanova

Differential Revision: D52737612

Pulled By: kagamiori

fbshipit-source-id: c82d55a592b85a16bce5c29b20d22f7a19c6c9a3
  • Loading branch information
rui-mo authored and facebook-github-bot committed Jan 19, 2024
1 parent f0ac5fa commit 3cf1f34
Showing 1 changed file with 0 additions and 29 deletions.
29 changes: 0 additions & 29 deletions velox/core/QueryConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,25 +101,6 @@ class QueryConfig {
static constexpr const char* kCastMatchStructByName =
"cast_match_struct_by_name";

/// If set, cast from float/double/decimal/string to integer truncates the
/// decimal part, otherwise rounds.
static constexpr const char* kCastToIntByTruncate = "cast_to_int_by_truncate";

/// If set, cast from string to date allows only ISO 8601 formatted strings:
/// [+-](YYYY-MM-DD). Otherwise, allows all patterns supported by Spark:
/// `[+-]yyyy*`
/// `[+-]yyyy*-[m]m`
/// `[+-]yyyy*-[m]m-[d]d`
/// `[+-]yyyy*-[m]m-[d]d *`
/// `[+-]yyyy*-[m]m-[d]dT*`
/// The asterisk `*` in `yyyy*` stands for any numbers.
/// For the last two patterns, the trailing `*` can represent none or any
/// sequence of characters, e.g:
/// "1970-01-01 123"
/// "1970-01-01 (BC)"
static constexpr const char* kCastStringToDateIsIso8601 =
"cast_string_to_date_is_iso_8601";

/// Used for backpressure to block local exchange producers when the local
/// exchange buffer reaches or exceeds this size.
static constexpr const char* kMaxLocalExchangeBufferSize =
Expand Down Expand Up @@ -510,16 +491,6 @@ class QueryConfig {
return get<bool>(kCastMatchStructByName, false);
}

// TODO: to be removed.
bool isCastToIntByTruncate() const {
return get<bool>(kCastToIntByTruncate, false);
}

// TODO: to be removed.
bool isIso8601() const {
return get<bool>(kCastStringToDateIsIso8601, true);
}

bool codegenEnabled() const {
return get<bool>(kCodegenEnabled, false);
}
Expand Down

0 comments on commit 3cf1f34

Please sign in to comment.