Making changes to sum aggregate.

kgpai · Apr 10, 2024 · ad266a4 · ad266a4
1 parent 113502c
commit ad266a4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/.github/workflows/scheduled.yml b/.github/workflows/scheduled.yml
@@ -708,7 +708,11 @@ jobs:
           rm -rfv /tmp/aggregate_fuzzer_repro/*
           chmod -R 777 /tmp/aggregate_fuzzer_repro
           chmod +x velox_aggregation_fuzzer_test
+          echo "signatures folder"
+          ls /tmp/signatures/
+          echo "Biased functions:"
           cat /tmp/signatures/presto_aggregate_bias_functions
+          echo "Running Fuzzer"
           ./velox_aggregation_fuzzer_test \
                 --seed ${RANDOM} \
                 --duration_sec $DURATION \

diff --git a/velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp b/velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp
@@ -1140,6 +1140,7 @@ exec::AggregateRegistrationResult registerMinMaxBy(
                            .argumentType("C")
                            .build());
   const std::vector<std::string> supportedCompareTypes = {
+      "boolean",
       "tinyint",
       "smallint",
       "integer",

diff --git a/velox/functions/prestosql/aggregates/SumAggregate.cpp b/velox/functions/prestosql/aggregates/SumAggregate.cpp
@@ -48,7 +48,7 @@ exec::AggregateRegistrationResult registerSum(
           .build(),
   };
 
-  for (const auto& inputType : {"tinyint", "smallint", "integer", "bigint"}) {
+  for (const auto& inputType : {"smallint", "integer", "bigint"}) {
     signatures.push_back(exec::AggregateFunctionSignatureBuilder()
                              .returnType("bigint")
                              .intermediateType("bigint")