fixed setAttribute/removeAttribute logic for use AFRAME components wi…

…th empty data
khlevon · May 21, 2019 · d5213fa · d5213fa
1 parent b5c064a
commit d5213fa
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -19,7 +19,11 @@ function doSetAttribute (el, props, propName) {
   } else if (props[propName] && props[propName].constructor === Function) {
     return;
   } else {
-    el.setAttribute(propName, props[propName]);
+    let val = props[propName];
+    if(val === undefined || val === null){
+      val = "";
+    }
+    el.setAttribute(propName, val);
   }
 }
 
@@ -45,7 +49,7 @@ function updateAttributes (el, prevProps, props) {
   if (prevProps) {
     for (propName in prevProps) {
       if (!filterNonEntityPropNames(propName)) { continue; }
-      if (props[propName] === undefined) { el.removeAttribute(propName); }
+      if (Object.keys(props).indexOf(propName) === -1) { el.removeAttribute(propName); }
     }
   }
 }