Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the light and dark theme icon #1596

Merged
merged 7 commits into from
Aug 10, 2024
Merged

Conversation

nikki-05
Copy link
Contributor

@nikki-05 nikki-05 commented Aug 8, 2024

Description

-Replaced the sun image
-Implemented the light theme toggling properly
-added JavaScript to toggle the theme by switching the icon between moon and sun images on click and updating the body class to reflect the corresponding theme.

Related Issues

Fixes issue #1419

Type of PR

  • [ x ] Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Screenshot 2024-08-08 221952
Screenshot 2024-08-08 222001

Checklist

  • [ x ] I have gone through the contributing guide
  • [ x ] I have updated my branch and synced it with project main branch before making this PR
  • [ x ] I have performed a self-review of my code
  • [ x ] I have tested the changes thoroughly before submitting this pull request.
  • [ x ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ x ] I have commented my code, particularly in hard-to-understand areas.

-Replaced the sun image
-Implemented the light theme toggling properly
Copy link

github-actions bot commented Aug 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for foodies-ordering-website ready!

Name Link
🔨 Latest commit 95bbb34
🔍 Latest deploy log https://app.netlify.com/sites/foodies-ordering-website/deploys/66b713ee1c659700081c9383
😎 Deploy Preview https://deploy-preview-1596--foodies-ordering-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nikki-05
Copy link
Contributor Author

nikki-05 commented Aug 8, 2024

Hi @khushi-joshi-05, I made the necessary changes if any changes are required, please do tell.

@sunny0625 sunny0625 added gssoc GSSOC'24 issues level1 labels Aug 9, 2024
@sunny0625
Copy link
Collaborator

solve conflicts.

@nikki-05
Copy link
Contributor Author

nikki-05 commented Aug 10, 2024

solve conflicts.

I resolved the conflicts

@sunny0625 sunny0625 merged commit 446b313 into khushi-joshi-05:main Aug 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSOC'24 issues level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Misalignment of the dark toggle mode button
2 participants