Improved File Name Extraction in getFileNameFromUrl Function

[MehdiSekoba]

In the original implementation, the getFileNameFromUrl function generated a file name by combining a random UUID with the file name guessed by URLUtil.guessFileName. This approach worked, but it did not always ensure that the file name was directly extracted from the URL.

Original Code:

fun getFileNameFromUrl(url: String): String {
    val guessFileName = URLUtil.guessFileName(url, null, null)
    return UUID.randomUUID().toString() + "-" + guessFileName
}

My Changes:

I modified the function to directly extract the file name from the URL itself, specifically by using the Uri class. Here's the updated implementation:

fun getFileNameFromUrl(url: String): String? {
    return if (URLUtil.isValidUrl(url)) {
        val uri = Uri.parse(url)
        uri.lastPathSegment
    } else {
        null
    }
}

Key Improvements:

1. Direct File Name Extraction:

   • Instead of appending a UUID, the new implementation directly retrieves the file name from the last path segment of the URL using uri.lastPathSegment.

2. Validation:

   • The function now validates the URL using URLUtil.isValidUrl. If the URL is invalid, the function returns null instead of proceeding with incorrect data.

3. Cleaner and More Intuitive Naming:

   • The downloaded file retains the exact name specified in the URL, which is more predictable and user-friendly.

Benefits:

• Ensures that file names remain consistent with the URL's actual content.
• Simplifies the logic by removing the need to append a random UUID.
• Adds error handling for invalid URLs, preventing unexpected behavior.