Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media downloading indexing options (round 2) #14

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

kieraneglin
Copy link
Owner

What's new?

Adds a lot of new options to the MediaProfile model, one option to the Source model, and some filepath trackers to the MediaItem model. For each of these options, you can assume the appropriate option builder(s)/metadata parser/views have been updated accordingly:

New fields on MediaProfile

  • download_thumbnail (boolean)
  • embed_thumbnail (boolean)
  • download_metadata (boolean)
  • embed_metadata (boolean)
  • shorts_behaviour (string enum)
    • Controls whether to exclude shorts, download only shorts, or not treat them differently (default)
  • livestream_behaviour (string enum)
    • Same as above but for livestreams

New field on Source

  • download_media (boolean)
    • Controls whether a source actually downloads things or just indexes content (ostensibly for future download)

New fields on MediaItem

  • thumbnail_filepath (string)
  • metadata_filepath (string)

Other additions:

  • generally, adds a workflow to parse/include options for the media indexing task
  • adds IndexOptionBuilder to work towards the above

What's changed?

  • enqueue_pending_media_downloads and the download worker now respect the source's download_media option, running a no-op if media shouldn't be downloaded
  • get_video_ids can now take a source instead of just a URL. When given a source, options may be applied to the yt-dlp call as appropriate

What's fixed?

N/A

Any other comments?

N/A

@kieraneglin kieraneglin self-assigned this Feb 6, 2024
@kieraneglin kieraneglin merged commit 013b2cc into master Feb 6, 2024
1 check passed
@kieraneglin kieraneglin deleted the ke/media-downloading-indexing-options-v2 branch February 6, 2024 23:36
kieraneglin added a commit that referenced this pull request Mar 29, 2024
* Adds options + option builder + metadata parsing for media thumbnails

* Added release-type options to media profile; built option parser for indexing operations

* Added new media_profile options to creation form; made show helper for rendering database items

* Added options for downloading/embedding metadata

* Adds option on sources to not download media (index only)

* reformatted docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant