Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete media items #20

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Delete media items #20

merged 5 commits into from
Feb 15, 2024

Conversation

kieraneglin
Copy link
Owner

What's new?

  • Adds methods for deleting media item attachments
  • Adds method for listing all attachments of a media item
  • Adds controller + UI for deleting a media item

What's changed?

  • Update test runner to ensure tmp filepaths exist

What's fixed?

  • Fixes bug where flash messages would get hidden under the navbar

Any other comments?

N/A

@kieraneglin kieraneglin added bug Something isn't working enhancement New feature or request UI labels Feb 15, 2024
@kieraneglin kieraneglin self-assigned this Feb 15, 2024
@kieraneglin kieraneglin merged commit 9d3b9cc into master Feb 15, 2024
1 check passed
@kieraneglin kieraneglin deleted the ke/delete-media-item branch February 15, 2024 21:51
kieraneglin added a commit that referenced this pull request Mar 29, 2024
@kieraneglin
Delete media items (#20)
c5fcb8f 
* Added method for deleting media files and their content

* Adds controllers and methods for deleting media and files

* Improved tmpfile setup and teardown for tests

* Actually got tmpfile cleanup running once per suite run

* Finally fixed flash messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kieraneglin kieraneglin

Labels
bug Something isn't working enhancement New feature or request UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kieraneglin