Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Update config options to enhance NixOS compatibility #493

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

kieraneglin
Copy link
Owner

@kieraneglin kieraneglin commented Dec 4, 2024

What's new?

  • Makes download and config locations configurable to allow for easier use with NixOS

What's changed?

N/A

What's fixed?

N/A

Any other comments?

N/A

@charludo
Copy link

charludo commented Dec 7, 2024

Wow, that was quick, thank you!

Looks like these changes were sufficient - I was able to successfully package the project and it runs natively on NixOS now! 🥳

I'd rather wait with opening my PR in nixpkgs until this PR is merged into main (or if possible, a new release took place) - but no rush, this is not urgent 😄

@kieraneglin kieraneglin changed the title [WIP] Nix Packaging [Housekeeping] Update config options to enhance NixOS compatibility Dec 10, 2024
@kieraneglin kieraneglin marked this pull request as ready for review December 10, 2024 22:18
@kieraneglin kieraneglin merged commit 83b1fa2 into master Dec 10, 2024
1 check passed
@kieraneglin kieraneglin deleted the ke/nix-packaging branch December 10, 2024 22:19
@kieraneglin
Copy link
Owner Author

@charludo Merged! I'll get that out in a release later today 🎉

@charludo
Copy link

charludo commented Dec 11, 2024

@charludo Merged! I'll get that out in a release later today 🎉

Awesome, looking forward to it!

You're fast 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants